Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1269253003: Add /bigobj to all builds on Windows. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add /bigobj to all builds on Windows. This is set in GYP for all compiler invocations. In GN it was only set in one place in content. This brings GN closer to GYP. Committed: https://crrev.com/2d5b2103b272a6ad9ad183e710ff82835226c18b Cr-Commit-Position: refs/heads/master@{#342230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 4 months ago (2015-08-06 21:44:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269253003/1
5 years, 4 months ago (2015-08-06 21:45:34 UTC) #4
jam
lgtm
5 years, 4 months ago (2015-08-06 22:43:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269253003/1
5 years, 4 months ago (2015-08-06 22:45:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 23:21:42 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 23:22:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d5b2103b272a6ad9ad183e710ff82835226c18b
Cr-Commit-Position: refs/heads/master@{#342230}

Powered by Google App Engine
This is Rietveld 408576698