Issue 1269223002: Quick fix in Consts.cpp to make tests pass after the clang-format CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1269223002: Quick fix in Consts.cpp to make tests pass after the clang-format CL. (Closed)

Created:
5 years, 4 months ago by Lei Zhang

Modified:
5 years, 4 months ago

Reviewers:
Tom Sepez, Nico

CC:
pdfium-reviews_googlegroups.com, Nico

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	fpdfsdk/src/javascript/Consts.cpp	View		1 chunk	+10 lines, -10 lines	0 comments	Download

Total messages: 6 (1 generated)

Lei Zhang

TBR, just to get the bots green. I'll look into making this work with clang-format ...

5 years, 4 months ago (2015-08-04 19:48:22 UTC) #1

Lei Zhang

Committed patchset #1 (id:1) manually as 5d711cb33cebaaf194b40683359c74e648ac5342 (tree was closed).

5 years, 4 months ago (2015-08-04 19:48:39 UTC) #2

Tom Sepez

On 2015/08/04 19:48:59, Nico (hiding) wrote: > lgtm, thanks! Yeah, the #-macro isn't buying us ...

5 years, 4 months ago (2015-08-04 19:57:53 UTC) #5

Nico

5 years, 4 months ago (2015-08-04 20:01:39 UTC) #6

Message was sent while issue was closed.

djasper suggests that we could mark these lines with // clang-format off, but
not having clever macros like this is probably even better.