Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1269183002: [turbofan] Handle void returns in instruction selector. (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Handle void returns in instruction selector. R=jarin@chromium.org BUG= Committed: https://crrev.com/6b63aa06d31c3ca8d24c61165491636f977d90c1 Cr-Commit-Position: refs/heads/master@{#29999}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M src/compiler/instruction-selector.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 4 months ago (2015-08-04 12:24:16 UTC) #1
Jarin
lgtm https://codereview.chromium.org/1269183002/diff/1/src/compiler/instruction-selector.cc File src/compiler/instruction-selector.cc (right): https://codereview.chromium.org/1269183002/diff/1/src/compiler/instruction-selector.cc#newcode1004 src/compiler/instruction-selector.cc:1004: Emit(kArchRet, g.NoOutput(), g.Use(value)); Any reason for calling g.Use(value)? ...
5 years, 4 months ago (2015-08-04 12:38:30 UTC) #2
titzer
On 2015/08/04 12:38:30, Jarin wrote: > lgtm > > https://codereview.chromium.org/1269183002/diff/1/src/compiler/instruction-selector.cc > File src/compiler/instruction-selector.cc (right): > ...
5 years, 4 months ago (2015-08-04 12:49:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269183002/20001
5 years, 4 months ago (2015-08-04 12:49:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-04 13:14:14 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 13:14:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b63aa06d31c3ca8d24c61165491636f977d90c1
Cr-Commit-Position: refs/heads/master@{#29999}

Powered by Google App Engine
This is Rietveld 408576698