Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 126913002: Enable most of GCM API tests on Windows (Closed)

Created:
6 years, 11 months ago by jianli
Modified:
6 years, 11 months ago
Reviewers:
fgorski
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Enable most of GCM API tests on Windows GCM API tests disabled on Windows due to the failure on official window builds. Most of them are not enabled with the help from using ScopedCurrentChannel trick. BUG=324982 TEST=Enabling tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -37 lines) Patch
M chrome/browser/extensions/api/gcm/gcm_apitest.cc View 9 chunks +10 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jianli
6 years, 11 months ago (2014-01-07 23:02:14 UTC) #1
fgorski
lgtm
6 years, 11 months ago (2014-01-07 23:09:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/126913002/1
6 years, 11 months ago (2014-01-07 23:13:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242887
6 years, 11 months ago (2014-01-08 01:34:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/126913002/1
6 years, 11 months ago (2014-01-08 01:42:24 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 07:12:03 UTC) #6
Message was sent while issue was closed.
Change committed as 243508

Powered by Google App Engine
This is Rietveld 408576698