Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: Source/core/layout/LayoutBlock.cpp

Issue 1269123002: Preparation for combining paths of focus rings and outlines (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove debug from fast/css/focus-ring-recursive-continuations.html Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutBlock.cpp
diff --git a/Source/core/layout/LayoutBlock.cpp b/Source/core/layout/LayoutBlock.cpp
index cf0cfe2d7645759552003b1fbb798ab301c5df1a..badc7785b8b72716b8de09760e668a4364650ef9 100644
--- a/Source/core/layout/LayoutBlock.cpp
+++ b/Source/core/layout/LayoutBlock.cpp
@@ -2556,7 +2556,7 @@ LayoutRect LayoutBlock::localCaretRect(InlineBox* inlineBox, int caretOffset, La
return caretRect;
}
-void LayoutBlock::addFocusRingRects(Vector<LayoutRect>& rects, const LayoutPoint& additionalOffset) const
+void LayoutBlock::addOutlineRects(Vector<LayoutRect>& rects, const LayoutPoint& additionalOffset) const
{
// For blocks inside inlines, we go ahead and include margins so that we run right up to the
// inline boxes above and below us (thus getting merged with them to form a single irregular
@@ -2590,18 +2590,18 @@ void LayoutBlock::addFocusRingRects(Vector<LayoutRect>& rects, const LayoutPoint
rects.append(rect);
}
- addFocusRingRectsForNormalChildren(rects, additionalOffset);
+ addOutlineRectsForNormalChildren(rects, additionalOffset);
if (TrackedLayoutBoxListHashSet* positionedObjects = this->positionedObjects()) {
for (auto* box : *positionedObjects)
- addFocusRingRectsForDescendant(*box, rects, additionalOffset);
+ addOutlineRectsForDescendant(*box, rects, additionalOffset);
}
}
if (inlineElementContinuation) {
- Vector<LayoutRect> inlineFocusRingRects;
+ Vector<LayoutRect> inlineOutlineRects;
// We need to give the LayoutInline a clean vector to let it add focus ring rects of line boxes.
- inlineElementContinuation->addFocusRingRects(inlineFocusRingRects, additionalOffset + (inlineElementContinuation->containingBlock()->location() - location()));
- rects.appendVector(inlineFocusRingRects);
+ inlineElementContinuation->addOutlineRects(inlineOutlineRects, additionalOffset + (inlineElementContinuation->containingBlock()->location() - location()));
+ rects.appendVector(inlineOutlineRects);
}
}

Powered by Google App Engine
This is Rietveld 408576698