service/memcache/raw_interface.go - Issue 1269113005: A transparent cache for datastore, backed by memcache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/memcache/raw_interface.go

Issue 1269113005: A transparent cache for datastore, backed by memcache. (Closed) Base URL: https://github.com/luci/gae.git@add_meta

Patch Set: some minor comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: service/memcache/raw_interface.go

diff --git a/service/memcache/raw_interface.go b/service/memcache/raw_interface.go

index 041b40753d1f66b20a377e3fd161345b290a0ede..5c3536a321df32820c218d2da1f509ad882bffa7 100644

--- a/service/memcache/raw_interface.go

+++ b/service/memcache/raw_interface.go

@@ -8,7 +8,8 @@ package memcache

type RawCB func(error)

// RawItemCB is the callback for RawInterface.GetMulti. It takes the retrieved

-// item and the error for that item (e.g. ErrCacheMiss) if there was one..

+// item and the error for that item (e.g. ErrCacheMiss) if there was one. Item

+// is guaranteed to be nil if error is not nil.

type RawItemCB func(Item, error)

// RawInterface is the full interface to the memcache service.