Rewrite non-temporal instructions

src/trusted/validator/validation_rewrite_32_test.cc

 /*
  * Copyright 2015 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
+#include <string.h>

[Mark Seaborn, 2015/08/14 21:12:59]

Nit: add empty line after this, to separate standard library #includes

[ruiq, 2015/08/15 04:46:40]

Done.

 #include "gtest/gtest.h"
 
 #include "native_client/src/shared/platform/nacl_log.h"
 #include "native_client/src/shared/utils/types.h"
 #include "native_client/src/trusted/validator/ncvalidate.h"
 
 #define CODE_SIZE 32
 #define NOP 0x90
-#define MOVNTI_CODE_SIZE 8
 
-// mov %edi,%edi; movnti %rax,0x68(%r15,%rdi,1)
-const char* movnti_code = "\x89\xff\x49\x0f\xc3\x44\x3f\x68";
+extern "C" {
+  extern const char no_rewrite_code[];
+  extern const char no_rewrite_code_post_rewrite[];
+  extern const char movntq_code[];
+  extern const char movntq_code_post_rewrite[];
+  extern const char movntdq_code[];
+  extern const char movntdq_code_post_rewrite[];
+}
 
-class ValidationDisableNonTemporalsTests : public ::testing::Test {
+class ValidationMovntRewriteTests : public ::testing::Test {
  protected:
   NaClValidationMetadata *metadata_ptr;
   const struct NaClValidatorInterface *validator;
   NaClCPUFeatures *cpu_features;
 
   unsigned char code_buffer[CODE_SIZE];
 
   void SetUp() {
     metadata_ptr = NULL;
     validator = NaClCreateValidator();
     cpu_features = (NaClCPUFeatures *) malloc(validator->CPUFeatureSize);
     EXPECT_NE(cpu_features, (NaClCPUFeatures *) NULL);
     memset(cpu_features, 0, validator->CPUFeatureSize);
     validator->SetAllCPUFeatures(cpu_features);
     memset(code_buffer, NOP, sizeof(code_buffer));
   }
 
   NaClValidationStatus Validate(uint32_t flags) {
-    return validator->Validate(0, code_buffer, 32,
+    return validator->Validate(0, code_buffer, CODE_SIZE,
                                FALSE,  /* stubout_mode */
                                flags,
                                FALSE,  /* readonly_test */
                                cpu_features,
                                metadata_ptr,
                                NULL);
   }
 
   void TearDown() {
     free(cpu_features);
   }
 };
 
-TEST_F(ValidationDisableNonTemporalsTests, NotDisableNonTemporals) {
-  memcpy(code_buffer, movnti_code, MOVNTI_CODE_SIZE);
-  NaClValidationStatus status = Validate(0);
-  // If we are not disabling non-temporal instructions, use the original
-  // validation rule, i.e., allow them. In future, we will do rewriting.
-  EXPECT_EQ(NaClValidationSucceeded, status);
-  // Code should not change.
-  EXPECT_EQ(0, memcmp(code_buffer, movnti_code, MOVNTI_CODE_SIZE));
+TEST_F(ValidationMovntRewriteTests, DisableNonTemporalsNoRewrite) {
+  memcpy(code_buffer, no_rewrite_code, strlen(no_rewrite_code));
+  NaClValidationStatus status = Validate(NACL_DISABLE_NONTEMPORALS_X86);
+  EXPECT_EQ(NaClValidationFailed, status);
+  EXPECT_EQ(0, memcmp(code_buffer,
+                      no_rewrite_code_post_rewrite,
+                      strlen(no_rewrite_code_post_rewrite)));
 }
 
-TEST_F(ValidationDisableNonTemporalsTests, DisableNonTemporals) {
-  memcpy(code_buffer, movnti_code, MOVNTI_CODE_SIZE);
-  NaClValidationStatus status = Validate(NACL_DISABLE_NONTEMPORALS_X86);
-  // Disable non-temporal instructions.
-  EXPECT_EQ(NaClValidationFailed, status);
-  // Code should not change.
-  EXPECT_EQ(0, memcmp(code_buffer, movnti_code, MOVNTI_CODE_SIZE));
+TEST_F(ValidationMovntRewriteTests, RewriteMovntq) {
+  memcpy(code_buffer, movntq_code, strlen(movntq_code));
+  NaClValidationStatus status = Validate(0);
+  EXPECT_EQ(NaClValidationSucceeded, status);
+  EXPECT_EQ(0, memcmp(code_buffer,
+                      movntq_code_post_rewrite,
+                      strlen(movntq_code_post_rewrite)));
+}
+
+TEST_F(ValidationMovntRewriteTests, RewriteMovntdq) {
+  memcpy(code_buffer, movntdq_code, strlen(movntdq_code));
+  NaClValidationStatus status = Validate(0);
+  EXPECT_EQ(NaClValidationSucceeded, status);
+  EXPECT_EQ(0, memcmp(code_buffer,
+                      movntdq_code_post_rewrite,
+                      strlen(movntdq_code_post_rewrite)));
 }
 
 int main(int argc, char *argv[]) {
   // The IllegalInst test touches the log mutex deep inside the validator.
   // This causes an SEH exception to be thrown on Windows if the mutex is not
   // initialized.
   // http://code.google.com/p/nativeclient/issues/detail?id=1696
   NaClLogModuleInit();
   testing::InitGoogleTest(&argc, argv);
   return RUN_ALL_TESTS();
 }