Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: gm/tests/run.sh

Issue 12691009: gm: write all messages to stdout/stderr with "GM:" preamble to distinguish from various debug messa… (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: tiny fix Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gm/gmmain.cpp ('K') | « gm/tests/outputs/no-readpath/output-expected/stdout ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/tests/run.sh
===================================================================
--- gm/tests/run.sh (revision 8115)
+++ gm/tests/run.sh (working copy)
@@ -60,7 +60,7 @@
mkdir -p $ACTUAL_OUTPUT_DIR
COMMAND="$GM_BINARY $GM_ARGS --writeJsonSummary $JSON_SUMMARY_FILE"
echo "$COMMAND" >$ACTUAL_OUTPUT_DIR/command_line
- $COMMAND &>$ACTUAL_OUTPUT_DIR/stdout
+ $COMMAND >$ACTUAL_OUTPUT_DIR/stdout 2>$ACTUAL_OUTPUT_DIR/stderr
echo $? >$ACTUAL_OUTPUT_DIR/return_value
# Only compare selected lines in the stdout, to ignore any spurious lines
@@ -68,10 +68,10 @@
#
# TODO(epoger): This is still hacky... we need to rewrite this script in
# Python soon, and make stuff like this more maintainable.
- grep --regexp=^reading --regexp=^writing --regexp=^drawing \
- --regexp=^FAILED --regexp=^Ran $ACTUAL_OUTPUT_DIR/stdout \
- >$ACTUAL_OUTPUT_DIR/stdout-tmp
+ grep ^GM: $ACTUAL_OUTPUT_DIR/stdout >$ACTUAL_OUTPUT_DIR/stdout-tmp
mv $ACTUAL_OUTPUT_DIR/stdout-tmp $ACTUAL_OUTPUT_DIR/stdout
+ grep ^GM: $ACTUAL_OUTPUT_DIR/stderr >$ACTUAL_OUTPUT_DIR/stderr-tmp
+ mv $ACTUAL_OUTPUT_DIR/stderr-tmp $ACTUAL_OUTPUT_DIR/stderr
compare_directories $EXPECTED_OUTPUT_DIR $ACTUAL_OUTPUT_DIR
}
« gm/gmmain.cpp ('K') | « gm/tests/outputs/no-readpath/output-expected/stdout ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698