Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1269093002: remove SkDeferredCanvas (Closed)

Created:
5 years, 4 months ago by reed1
Modified:
5 years, 4 months ago
Reviewers:
junov1, Justin Novosad
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove SkDeferredCanvas Waiting a day or so to see if the blink-removal of SkDeferredCanvas sticks BUG=skia: Committed: https://skia.googlesource.com/skia/+/451af5062e6bf9c665126d84516e0baafa27ecc4

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2430 lines) Patch
D bench/DeferredSurfaceCopyBench.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
M dm/DM.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 2 chunks +1 line, -26 lines 0 comments Download
M gyp/utils.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M include/core/SkCanvas.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkDevice.h View 1 1 chunk +0 lines, -1 line 0 comments Download
D include/utils/SkDeferredCanvas.h View 1 chunk +0 lines, -261 lines 0 comments Download
M samplecode/SampleApp.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 8 chunks +1 line, -19 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
D src/utils/SkDeferredCanvas.cpp View 1 1 chunk +0 lines, -1027 lines 0 comments Download
M tests/CanvasTest.cpp View 1 5 chunks +0 lines, -62 lines 0 comments Download
D tests/DeferredCanvasTest.cpp View 1 1 chunk +0 lines, -949 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269093002/1
5 years, 4 months ago (2015-08-03 16:46:21 UTC) #2
reed1
5 years, 4 months ago (2015-08-03 17:35:09 UTC) #5
Justin Novosad
On 2015/08/03 17:35:09, reed1 wrote: Let's wait to make sure the blink patch sticks.
5 years, 4 months ago (2015-08-03 19:10:23 UTC) #6
Justin Novosad
On 2015/08/03 19:10:23, Justin Novosad wrote: > On 2015/08/03 17:35:09, reed1 wrote: > > Let's ...
5 years, 4 months ago (2015-08-03 19:11:33 UTC) #7
reed1
likely we can remove pipe, but it had some value before deferred canvas, so I ...
5 years, 4 months ago (2015-08-04 17:12:00 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269093002/20001
5 years, 4 months ago (2015-08-19 13:25:07 UTC) #10
reed1
LETS LAND THIS SUCKER
5 years, 4 months ago (2015-08-19 13:30:19 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 13:31:16 UTC) #13
Justin Novosad
On 2015/08/19 13:31:16, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 4 months ago (2015-08-19 15:05:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269093002/20001
5 years, 4 months ago (2015-08-19 15:15:21 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 15:18:06 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/451af5062e6bf9c665126d84516e0baafa27ecc4

Powered by Google App Engine
This is Rietveld 408576698