Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: runtime/observatory/lib/src/elements/instance_ref.html

Issue 1269083006: Remember when a variable has been expanded/unexpanded in the debugger. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/instance_ref.html
diff --git a/runtime/observatory/lib/src/elements/instance_ref.html b/runtime/observatory/lib/src/elements/instance_ref.html
index 91c539b9c9b7ec4d1dfd952daa87b247ef9916bc..47819725059febc5f14b19b581c1ab52ac066237 100644
--- a/runtime/observatory/lib/src/elements/instance_ref.html
+++ b/runtime/observatory/lib/src/elements/instance_ref.html
@@ -50,7 +50,7 @@
<template if="{{ ref.isPlainInstance }}">
<a on-click="{{ goto }}" _href="{{ url }}"><em>{{ ref.clazz.name }}</em></a>
- <curly-block callback="{{ expander() }}">
+ <curly-block callback="{{ expander() }}" expandKey="{{ expandKey }}">
<div class="memberList">
<template repeat="{{ field in ref.fields }}">
<div class="memberItem">
@@ -58,7 +58,9 @@
{{ field['decl'].name }}
</div>
<div class="memberValue">
- <any-service-ref ref="{{ field['value'] }}"></any-service-ref>
+ <any-service-ref ref="{{ field['value'] }}"
+ expandKey="{{ makeExpandKey(field['decl'].name) }}">
+ </any-service-ref>
</div>
</div>
</template>
@@ -68,13 +70,14 @@
<template if="{{ ref.isList }}">
<a on-click="{{ goto }}" _href="{{ url }}"><em>{{ ref.clazz.name }}</em> ({{ ref.length }})</a>
- <curly-block callback="{{ expander() }}">
+ <curly-block callback="{{ expander() }}" expandKey="{{ expandKey }}">
<div class="memberList">
<template repeat="{{ index in ref.elements.asMap().keys }}">
<div class="memberItem">
<div class="memberName">[{{ index }}]</div>
<div class="memberValue">
- <any-service-ref ref="{{ ref.elements[index] }}">
+ <any-service-ref ref="{{ ref.elements[index] }}"
+ expandKey="{{ makeExpandKey(index.toString()) }}">
</any-service-ref>
</div>
</div>
@@ -85,15 +88,19 @@
<template if="{{ ref.isMap }}">
<a on-click="{{ goto }}" _href="{{ url }}"><em>{{ ref.clazz.name }}</em> ({{ ref.length }})</a>
- <curly-block callback="{{ expander() }}">
+ <curly-block callback="{{ expander() }}" expandKey="{{ expandKey }}">
<div class="memberList">
<template repeat="{{ association in ref.associations }}">
<div class="memberItem">
<div class="memberName">
- [<any-service-ref ref="{{ association['key'] }}"></any-service-ref>]
+ [<any-service-ref ref="{{ association['key'] }}"
+ expandKey="{{ makeExpandKey('key') }}">
+ </any-service-ref>]
</div>
<div class="memberValue">
- <any-service-ref ref="{{ association['value'] }}"></any-service-ref>
+ <any-service-ref ref="{{ association['value'] }}"
+ expandKey="{{ makeExpandKey('value') }}">
+ </any-service-ref>
</div>
</div>
</template>
@@ -103,7 +110,7 @@
<template if="{{ ref.isTypedData }}">
<a on-click="{{ goto }}" _href="{{ url }}"><em>{{ ref.clazz.name }}</em> ({{ ref.length }})</a>
- <curly-block callback="{{ expander() }}">
+ <curly-block callback="{{ expander() }}" expandKey="{{ expandKey }}">
<div class="memberList">
<template repeat="{{ index in ref.typedElements.asMap().keys }}">
<div class="memberItem">
@@ -117,12 +124,14 @@
<template if="{{ ref.isMirrorReference }}">
<a on-click="{{ goto }}" _href="{{ url }}"><em>{{ ref.clazz.name }}</em></a>
- <curly-block callback="{{ expander() }}">
+ <curly-block callback="{{ expander() }}" expandKey="{{ expandKey }}">
<div class="memberList">
<div class="memberItem">
<div class="memberName">referent</div>
<div class="memberValue">
- <any-service-ref ref="{{ ref.referent }}"></any-service-ref>
+ <any-service-ref ref="{{ ref.referent }}"
+ expandKey="{{ makeExpandKey('referent') }}">
+ </any-service-ref>
</div>
</div>
</div>
@@ -131,18 +140,22 @@
<template if="{{ ref.isWeakProperty }}">
<a on-click="{{ goto }}" _href="{{ url }}"><em>{{ ref.clazz.name }}</em></a>
- <curly-block callback="{{ expander() }}">
+ <curly-block callback="{{ expander() }}" expandKey="{{ expandKey }}">
<div class="memberList">
<div class="memberItem">
<div class="memberName">key</div>
<div class="memberValue">
- <any-service-ref ref="{{ ref.key }}"></any-service-ref>
+ <any-service-ref ref="{{ ref.key }}"
+ expandKey="{{ makeExpandKey('key') }}">
+ </any-service-ref>
</div>
</div>
<div class="memberItem">
<div class="memberName">value</div>
<div class="memberValue">
- <any-service-ref ref="{{ ref.value }}"></any-service-ref>
+ <any-service-ref ref="{{ ref.value }}"
+ expandKey="{{ makeExpandKey('value') }}">
+ </any-service-ref>
</div>
</div>
</div>
« no previous file with comments | « runtime/observatory/lib/src/elements/instance_ref.dart ('k') | runtime/observatory/lib/src/elements/service_ref.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698