Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: runtime/vm/compiler.cc

Issue 12690004: Run type propagation after LICM to ensure correct reaching types for hoisted values. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: remove test file Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/deopt_hoisted_smi_check_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index bc4444030a93d7b96b96c1b496a5f026b73960fc..d99341568bdd607ba3d126c0433420de0b0be252 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -259,6 +259,13 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
}
// The final canonicalization pass before the code generation.
+ if (FLAG_propagate_types) {
+ // Recompute types after code movement was done to ensure correct
+ // reaching types for hoisted values.
+ FlowGraphTypePropagator propagator(flow_graph);
+ propagator.Propagate();
+ DEBUG_ASSERT(flow_graph->VerifyUseLists());
+ }
optimizer.Canonicalize();
DEBUG_ASSERT(flow_graph->VerifyUseLists());
« no previous file with comments | « no previous file | tests/language/deopt_hoisted_smi_check_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698