dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart - Issue 12690003: Revert "Don't output tons of messages on apidoc." and "Fix bot breaks."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

Issue 12690003: Revert "Don't output tons of messages on apidoc." and "Fix bot breaks." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/library_loader.dart ('k') | dart/tests/utils/recursive_import_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart b/dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

index f82c44e0aac083c5f1b68300eedbe925437a8190..fc4e9b24ac0de57f0c84d66e401006fba50e8f0a 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

@@ -68,6 +68,7 @@ class FormattingDiagnosticHandler {

FormattingDiagnosticHandler(SourceFileProvider this.provider);

void info(var message, [api.Diagnostic kind = api.Diagnostic.VERBOSE_INFO]) {

+ if (!verbose && identical(kind, api.Diagnostic.VERBOSE_INFO)) return;

if (enableColors) {

print('${colors.green("info:")} $message');

} else {

@@ -79,7 +80,6 @@ class FormattingDiagnosticHandler {

api.Diagnostic kind) {

// TODO(ahe): Remove this when source map is handled differently.

if (identical(kind.name, 'source map')) return;

- if (!verbose && identical(kind, api.Diagnostic.VERBOSE_INFO)) return;

if (isAborting) return;

isAborting = identical(kind, api.Diagnostic.CRASH);

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/library_loader.dart ('k') | dart/tests/utils/recursive_import_test.dart » ('j') | no next file with comments »