Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 1268973003: Enhance GN string interpolation. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enhance GN string interpolation. This allows writing scope accesses ${invoker.foo} and list accesses ${sources[0]} inside bracketed string interpolation. Committed: https://crrev.com/f87ebd5381d93ab4540d66a525e6e1d058bd8f2b Cr-Commit-Position: refs/heads/master@{#341547}

Patch Set 1 #

Patch Set 2 : grammar #

Total comments: 2

Patch Set 3 : Review comments fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -70 lines) Patch
M tools/gn/parser.cc View 1 2 chunks +10 lines, -6 lines 0 comments Download
M tools/gn/string_utils.cc View 1 2 4 chunks +141 lines, -63 lines 0 comments Download
M tools/gn/string_utils_unittest.cc View 4 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268973003/20001
5 years, 4 months ago (2015-08-03 00:24:57 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-03 00:40:21 UTC) #4
brettw
5 years, 4 months ago (2015-08-03 04:50:24 UTC) #6
Dirk Pranke
lgtm https://codereview.chromium.org/1268973003/diff/20001/tools/gn/string_utils.cc File tools/gn/string_utils.cc (right): https://codereview.chromium.org/1268973003/diff/20001/tools/gn/string_utils.cc#newcode45 tools/gn/string_utils.cc:45: // non-general-purpose programming langhage. The main reason expressions ...
5 years, 4 months ago (2015-08-03 15:21:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268973003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268973003/40001
5 years, 4 months ago (2015-08-03 17:42:30 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-03 18:01:33 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 18:02:53 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f87ebd5381d93ab4540d66a525e6e1d058bd8f2b
Cr-Commit-Position: refs/heads/master@{#341547}

Powered by Google App Engine
This is Rietveld 408576698