Issue 1268933003: Memory reducer should use the current allocation rate instead of the overall allocation rate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1268933003: Memory reducer should use the current allocation rate instead of the overall allocation rate. (Closed)

Created:
5 years, 4 months ago by ulan

Modified:
5 years, 4 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Memory reducer should use the current allocation rate instead of the overall allocation rate. BUG=

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -5 lines)			Patch
M	src/heap/gc-tracer.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/heap/gc-tracer.cc	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/heap/heap.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/heap/memory-reducer.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ulan

PTAL In local testing I observed that memory reducer can time long time to kick ...

5 years, 4 months ago (2015-07-31 15:28:42 UTC) #2

ulan

5 years, 4 months ago (2015-08-04 11:27:36 UTC) #3

Message was sent while issue was closed.

On 2015/07/31 15:28:42, ulan wrote:
> PTAL
> 
> In local testing I observed that memory reducer can time long time to kick in
> because it doesn't use the current allocation rate.

Abandoning this CL since it can cause too aggressive GCs.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages