Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 126893002: Adds --auto_platform to download_from_google_storage. (Closed)

Created:
6 years, 11 months ago by Ryan Tseng
Modified:
6 years, 11 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Adds --auto_platform to download_from_google_storage. A very common pattern for the users of this script is to have binaries in three different folders, eg: some/folder/win/bin.exe some/folder/mac/bin some/folder/linux/bin Instead of using --platform to specify three different paths, we can recognize this usage and pass in --auto_platform, and then --directory some/folder/ as the target. When enumerating files, it will match each individual file to see if they have (win|mac|linux) as a parent folder name, and filter out non-matching platforms. BUG= TEST= src/third_party/clang_format/bin$ download_from_google_storage --auto_platform --no_auth -b chromium-clang-fomat -dr . 0> Downloading ./linux/clang-format... Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245643

Patch Set 1 #

Total comments: 16

Patch Set 2 : Review fixes, fixed infinite recursion bug #

Patch Set 3 : abs() fix #

Patch Set 4 : optparse fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -8 lines) Patch
M download_from_google_storage.py View 1 2 3 11 chunks +54 lines, -4 lines 0 comments Download
M tests/download_from_google_storage_unittests.py View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Tseng
I realized that almost everyone who uses this uses it for binaries, and almost always ...
6 years, 11 months ago (2014-01-07 23:59:37 UTC) #1
Ryan Tseng
ping?
6 years, 11 months ago (2014-01-17 19:38:42 UTC) #2
M-A Ruel
https://codereview.chromium.org/126893002/diff/1/download_from_google_storage.py File download_from_google_storage.py (right): https://codereview.chromium.org/126893002/diff/1/download_from_google_storage.py#newcode30 download_from_google_storage.py:30: 'darwin': 'mac', sort keys https://codereview.chromium.org/126893002/diff/1/download_from_google_storage.py#newcode131 download_from_google_storage.py:131: """Check if any ...
6 years, 11 months ago (2014-01-17 20:19:21 UTC) #3
Ryan Tseng
Thanks for the review, comments addressed, please take a look again. https://codereview.chromium.org/126893002/diff/1/download_from_google_storage.py File download_from_google_storage.py (right): ...
6 years, 11 months ago (2014-01-17 20:58:37 UTC) #4
M-A Ruel
lgtm
6 years, 11 months ago (2014-01-17 21:05:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/126893002/150001
6 years, 11 months ago (2014-01-17 22:26:18 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 22:28:32 UTC) #7
Message was sent while issue was closed.
Change committed as 245643

Powered by Google App Engine
This is Rietveld 408576698