Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1268853008:
adding gm to use random scaler context (Closed)
|
Created:
5 years, 4 months ago by joshua.litt Modified:
5 years, 4 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
Descriptionadding gm to use random scaler context
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/853336c532504b3436d7dcbf252419f00c79066d
Committed: https://skia.googlesource.com/skia/+/44c4851c91ac1779dfa5336defe05c251971cd45
Patch Set 1 #
Total comments: 1
Patch Set 2 : tweaks #Patch Set 3 : tweaks #Patch Set 4 : fix cpu #
Messages
Total messages: 22 (11 generated)
joshualitt@google.com changed reviewers: + bsalomon@google.com
joshualitt@google.com changed reviewers: + joshualitt@google.com
there are some other things I want to test, but this is a start. ptal.
lgtm. Is the image sensible to triage? https://codereview.chromium.org/1268853008/diff/1/gm/textblobrandomfont.cpp File gm/textblobrandomfont.cpp (right): https://codereview.chromium.org/1268853008/diff/1/gm/textblobrandomfont.cpp#n... gm/textblobrandomfont.cpp:31: const char* text = "The quick brown fox jumps over the lazy yellow dog."; yellow?
The CQ bit was checked by joshualitt@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/1268853008/#ps20001 (title: "tweaks")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268853008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268853008/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by joshualitt@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/1268853008/#ps40001 (title: "tweaks")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268853008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268853008/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by joshualitt@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/1268853008/#ps60001 (title: "fix cpu")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268853008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268853008/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/853336c532504b3436d7dcbf252419f00c79066d
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1259033004/ by joshualitt@google.com. The reason for reverting is: breaking bots.
The CQ bit was checked by joshualitt@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268853008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268853008/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/44c4851c91ac1779dfa5336defe05c251971cd45 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
