Issue 1268853007: Move SkOpts.h back to src/core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1268853007: Move SkOpts.h back to src/core. (Closed)

Created:
5 years, 4 months ago by mtklein_C

Modified:
5 years, 4 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Move SkOpts.h back to src/core. The Chrome opts targets (sse2, ssse3, sse41, etc) don't have include/private on their include path. This should unblock the roll. TBR=reed@google.com BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/bdb34d0345748f424e3c787ad9bbef04134c7e3b

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -35 lines)			Patch
M	include/core/SkUtils.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
D	include/private/SkOpts.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
A +	src/core/SkOpts.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268853007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268853007/1

5 years, 4 months ago (2015-07-31 20:52:24 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-07-31 21:02:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bdb34d0345748f424e3c787ad9bbef04134c7e3b

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages