Issue 126883002: Make RunLoop remove handle when a timeout is notified

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126883002: Make RunLoop remove handle when a timeout is notified (Closed)

Created:
6 years, 11 months ago by DaveMoore

Modified:
6 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make RunLoop remove handle when a timeout is notified BUG=None TEST=Added to existing tests R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243467

Patch Set 2 : Add const to HasHandler() #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
M	mojo/public/utility/run_loop.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/utility/run_loop.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	mojo/public/utility/run_loop_unittest.cc	View		3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/126883002/diff/1/mojo/public/utility/run_loop.h File mojo/public/utility/run_loop.h (right): https://codereview.chromium.org/126883002/diff/1/mojo/public/utility/run_loop.h#newcode40 mojo/public/utility/run_loop.h:40: bool HasHandler(const Handle& handle); nit: make const.

6 years, 11 months ago (2014-01-07 23:02:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/126883002/40001

6 years, 11 months ago (2014-01-07 23:23:28 UTC) #4

Message was sent while issue was closed.

Change committed as 243467

Expand Messages | Collapse Messages

Issue 126883002: Make RunLoop remove handle when a timeout is notified (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add const to HasHandler() #

Messages