Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Unified Diff: runtime/vm/service.cc

Issue 1268803006: Support profiler code transition tags (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 61d0e07f91a60d8908eb891bee0dc2ec01beabcd..6f4fd03d4d14791d0f72abcb848b08fda3063987 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2346,6 +2346,7 @@ static Profile::TagOrder tags_enum_values[] = {
static const MethodParameter* get_cpu_profile_params[] = {
ISOLATE_PARAMETER,
new EnumParameter("tags", true, tags_enum_names),
+ new BoolParameter("_codeTransitionTags", false),
NULL,
};
@@ -2354,7 +2355,11 @@ static const MethodParameter* get_cpu_profile_params[] = {
static bool GetCpuProfile(Isolate* isolate, JSONStream* js) {
Profile::TagOrder tag_order =
EnumMapper(js->LookupParam("tags"), tags_enum_names, tags_enum_values);
- ProfilerService::PrintJSON(js, tag_order);
+ intptr_t extra_tags = 0;
+ if (BoolParameter::Parse(js->LookupParam("_codeTransitionTags"))) {
+ extra_tags |= ProfilerService::kCodeTransitionTagsBit;
+ }
+ ProfilerService::PrintJSON(js, tag_order, extra_tags);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698