Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: runtime/vm/profiler_test.cc

Issue 1268803006: Support profiler code transition tags (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/profiler_test.cc
diff --git a/runtime/vm/profiler_test.cc b/runtime/vm/profiler_test.cc
index 5763abd24fb203128f5bac07186139f2c726d81c..965d6b3e08b16fd0ca8fbef8f3b5e2babd29a451 100644
--- a/runtime/vm/profiler_test.cc
+++ b/runtime/vm/profiler_test.cc
@@ -1076,6 +1076,86 @@ TEST_CASE(Profiler_FunctionInline) {
EXPECT_EQ(50000, walker.CurrentExclusiveTicks());
EXPECT(!walker.Down());
}
+
+ // Test code transition tags.
+ {
+ Isolate* isolate = Isolate::Current();
+ StackZone zone(isolate);
+ HANDLESCOPE(isolate);
+ Profile profile(isolate);
+ AllocationFilter filter(isolate, class_a.id());
+ profile.Build(&filter,
+ Profile::kNoTags,
+ ProfilerService::kCodeTransitionTagsBit);
+ // We should have 50,000 allocation samples.
+ EXPECT_EQ(50000, profile.sample_count());
+ ProfileTrieWalker walker(&profile);
+ // We have two code objects: mainA and B.boo.
+ walker.Reset(Profile::kExclusiveCode);
+ EXPECT(walker.Down());
+ EXPECT_STREQ("B.boo", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Optimized Code]", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("mainA", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Unoptimized Code]", walker.CurrentName());
+ EXPECT(!walker.Down());
+ // We have two code objects: mainA and B.boo.
+ walker.Reset(Profile::kInclusiveCode);
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Unoptimized Code]", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("mainA", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Optimized Code]", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("B.boo", walker.CurrentName());
+ EXPECT(!walker.Down());
+
+ // Inline expansion should show us the complete call chain:
+ // mainA -> B.boo -> B.foo -> B.choo.
+ walker.Reset(Profile::kExclusiveFunction);
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Inline End]", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("B.choo", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("B.foo", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Inline Start]", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("B.boo", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Optimized Code]", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("mainA", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Unoptimized Code]", walker.CurrentName());
+ EXPECT(!walker.Down());
+
+ // Inline expansion should show us the complete call chain:
+ // mainA -> B.boo -> B.foo -> B.choo.
+ walker.Reset(Profile::kInclusiveFunction);
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Unoptimized Code]", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("mainA", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Optimized Code]", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("B.boo", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Inline Start]", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("B.foo", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("B.choo", walker.CurrentName());
+ EXPECT(walker.Down());
+ EXPECT_STREQ("[Inline End]", walker.CurrentName());
+ EXPECT(!walker.Down());
+ }
}
} // namespace dart
+

Powered by Google App Engine
This is Rietveld 408576698