Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1268803004: Reland #2: Switch the default build configuration to use the 10.10 SDK. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Nico, amineer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #2: Switch the default build configuration to use the 10.10 SDK. The first reland caused Webkit layout test errors on 10.8 and 10.9. Those errors have been fixed. Original issue's description: > mac: Switch the default build configuration to use the 10.10 SDK. > > This change is intended to be temporary. The goal is to release a Canary > compiled against the 10.10 SDK, and then to revert this CL. > > BUG=463170 > > Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451 > Cr-Commit-Position: refs/heads/master@{#340992} TBR=thakis@chromium.org,amineer@chromium.org BUG=463170, 515836 Committed: https://crrev.com/a9cbe267748e0360f8c994a1c7209f86f33b944f Cr-Commit-Position: refs/heads/master@{#342870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/mac/mac_sdk.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268803004/1
5 years, 4 months ago (2015-08-11 17:40:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 19:31:35 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 19:32:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9cbe267748e0360f8c994a1c7209f86f33b944f
Cr-Commit-Position: refs/heads/master@{#342870}

Powered by Google App Engine
This is Rietveld 408576698