Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: runtime/vm/object_x64_test.cc

Issue 1268783003: Simplify constant pool usage in x64 code generator (by removing extra argument (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intrinsifier_x64.cc ('k') | runtime/vm/runtime_entry_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/assert.h" 5 #include "platform/assert.h"
6 #include "vm/globals.h" 6 #include "vm/globals.h"
7 #if defined(TARGET_ARCH_X64) 7 #if defined(TARGET_ARCH_X64)
8 8
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/object.h" 10 #include "vm/object.h"
(...skipping 17 matching lines...) Expand all
28 __ ret(); 28 __ ret();
29 } 29 }
30 30
31 31
32 // Generate a dart code sequence that embeds a string object in it. 32 // Generate a dart code sequence that embeds a string object in it.
33 // This is used to test Embedded String objects in the instructions. 33 // This is used to test Embedded String objects in the instructions.
34 void GenerateEmbedStringInCode(Assembler* assembler, const char* str) { 34 void GenerateEmbedStringInCode(Assembler* assembler, const char* str) {
35 const String& string_object = 35 const String& string_object =
36 String::ZoneHandle(String::New(str, Heap::kOld)); 36 String::ZoneHandle(String::New(str, Heap::kOld));
37 __ pushq(PP); // Save caller's pool pointer and load a new one here. 37 __ pushq(PP); // Save caller's pool pointer and load a new one here.
38 __ LoadPoolPointer(PP); 38 __ LoadPoolPointer();
39 __ LoadObject(RAX, string_object, PP); 39 __ LoadObject(RAX, string_object);
40 __ popq(PP); // Restore caller's pool pointer. 40 __ popq(PP); // Restore caller's pool pointer.
41 __ ret(); 41 __ ret();
42 } 42 }
43 43
44 44
45 // Generate a dart code sequence that embeds a smi object in it. 45 // Generate a dart code sequence that embeds a smi object in it.
46 // This is used to test Embedded Smi objects in the instructions. 46 // This is used to test Embedded Smi objects in the instructions.
47 void GenerateEmbedSmiInCode(Assembler* assembler, intptr_t value) { 47 void GenerateEmbedSmiInCode(Assembler* assembler, intptr_t value) {
48 const Smi& smi_object = Smi::ZoneHandle(Smi::New(value)); 48 const Smi& smi_object = Smi::ZoneHandle(Smi::New(value));
49 __ movq(RAX, Immediate(reinterpret_cast<int64_t>(smi_object.raw()))); 49 __ movq(RAX, Immediate(reinterpret_cast<int64_t>(smi_object.raw())));
50 __ ret(); 50 __ ret();
51 } 51 }
52 52
53 } // namespace dart 53 } // namespace dart
54 54
55 #endif // defined TARGET_ARCH_X64 55 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intrinsifier_x64.cc ('k') | runtime/vm/runtime_entry_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698