Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1268743002: Tweak the MaskFormat in one more place in GrBatchFontCache (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Tweak the MaskFormat in one more place in GrBatchFontCache BUG=510931 Committed: https://skia.googlesource.com/skia/+/76cc6575a4c1fc46c426d61252233cd48990d10d

Patch Set 1 #

Patch Set 2 : more correct #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/gpu/GrAtlasTextContext.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrBatchFontCache.h View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
joshualitt
ptal, this was exposed while I was writing a unittest
5 years, 4 months ago (2015-07-30 15:43:49 UTC) #2
robertphillips
lgtm
5 years, 4 months ago (2015-07-30 15:50:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268743002/1
5 years, 4 months ago (2015-07-30 16:15:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268743002/20001
5 years, 4 months ago (2015-07-30 16:34:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268743002/20001
5 years, 4 months ago (2015-07-31 12:48:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268743002/20001
5 years, 4 months ago (2015-07-31 12:51:12 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 12:51:47 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/76cc6575a4c1fc46c426d61252233cd48990d10d

Powered by Google App Engine
This is Rietveld 408576698