Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1268703002: Use argument groups for Android and desktop-only arguments. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use argument groups for Android and desktop-only arguments. This makes the `--help` output more readable. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c8fed9b2aa609b3edbd92467517b0842b3a701ea

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Remove comments not needed anymore. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M mojo/devtools/common/devtoolslib/shell_arguments.py View 1 2 2 chunks +14 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Ben, ptal.
5 years, 4 months ago (2015-07-30 12:20:59 UTC) #2
qsr
lgtm
5 years, 4 months ago (2015-07-30 12:22:03 UTC) #3
ppi
5 years, 4 months ago (2015-07-30 12:24:57 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c8fed9b2aa609b3edbd92467517b0842b3a701ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698