CSSValue Immediates: Micro-optimize reinterpret_casts for immediates

Source/core/css/CSSPrimitiveValue.h

 /*
  * (C) 1999-2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 427 matching lines @@
     inline bool isTaggedPtr() const
     {
         return reinterpret_cast<uintptr_t>(this) & 1;
     }
 
     static inline CSSPrimitiveValue* toPtr(CSSTaggedPtrValue taggedPtr)
     {
         return reinterpret_cast<CSSPrimitiveValue*&>(taggedPtr);
     }
 
-    inline CSSTaggedPtrValue toTaggedPtr() const
-    {
-        CSSPrimitiveValue* nonConstThis = const_cast<CSSPrimitiveValue*>(this);
-        return reinterpret_cast<CSSTaggedPtrValue&&>(nonConstThis);
-    }
-
     inline UnitType type() const
     {
         if (!isTaggedPtr())
             return static_cast<UnitType>(m_primitiveUnitType);
-        return static_cast<UnitType>(toTaggedPtr().type);
+
+        const CSSPrimitiveValue* const& lValue = this;
+        const CSSTaggedPtrValue& taggedPtr = reinterpret_cast<const CSSTaggedPtrValue&>(lValue);
+        return static_cast<UnitType>(taggedPtr.type);
     }
 
     inline CSSPrimitiveValueData value() const
     {
         if (!isTaggedPtr())
             return m_value;
 
         CSSPrimitiveValueData data;
+        const CSSPrimitiveValue* const& lValue = this;
+        const CSSTaggedPtrValue& taggedPtr = reinterpret_cast<const CSSTaggedPtrValue&>(lValue);
         switch (type()) {
         case CSSPrimitiveValue::CSS_PROPERTY_ID:
-            data.propertyID = static_cast<CSSPropertyID>(toTaggedPtr().value);
+            data.propertyID = static_cast<CSSPropertyID>(taggedPtr.value);
             break;
         case CSSPrimitiveValue::CSS_VALUE_ID:
-            data.valueID = static_cast<CSSValueID>(toTaggedPtr().value);
+            data.valueID = static_cast<CSSValueID>(taggedPtr.value);
             break;
         case CSSPrimitiveValue::CSS_RGBCOLOR: {
-            uintptr_t valueRawVar = toTaggedPtr().value;
-            packedColor color = *reinterpret_cast<packedColor*>(&valueRawVar);
+            uintptr_t colorRaw = taggedPtr.value;
+            packedColor color = reinterpret_cast<packedColor&>(colorRaw);
             unsigned alpha;
 #if CPU(32BIT)
             alpha = color.alpha == 1 ? 255 : 0;
 #elif CPU(64BIT)
             alpha = color.alpha;
 #endif
             data.rgbcolor = makeRGBA(color.red, color.green, color.blue, alpha);
             break;
         }
         default:
-            uint64_t shiftedValue = toTaggedPtr().value;
+            uint64_t shiftedValue = taggedPtr.value;
             shiftedValue = shiftedValue << doubleShiftAmount;
-            data.num = *reinterpret_cast<double*>(&shiftedValue);
+            data.num = reinterpret_cast<double&>(shiftedValue);
             break;
         }
         return data;
     }
 
     CSSPrimitiveValueData m_value;
 };
 
 typedef CSSPrimitiveValue::CSSLengthArray CSSLengthArray;
 typedef CSSPrimitiveValue::CSSLengthTypeArray CSSLengthTypeArray;
@@ skipping 11 matching lines @@
     // Immediates (non-pointers) end in a 1.
     if (!(reinterpret_cast<uintptr_t>(p) & 1))
         adopted(p);
     return PassRefPtr<blink::CSSPrimitiveValue>(p, PassRefPtr<blink::CSSPrimitiveValue>::AdoptRef);
 }
 #endif
 
 } // namespace WTF
 
 #endif // CSSPrimitiveValue_h