Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1268663004:
Add support for large object IsSlotInBlackObject to filter out all dead slots correctly. (Closed)
|
Created:
5 years, 4 months ago by Hannes Payer (out of office) Modified:
5 years, 4 months ago CC:
v8-dev, Igor Sheludko Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionAdd support for large object IsSlotInBlackObject to filter out all dead slots correctly.
BUG=chromium:454297
LOG=n
Committed: https://crrev.com/82e1069330a9cdc692602fef766d1aec5b9e9328
Cr-Commit-Position: refs/heads/master@{#29979}
Patch Set 1 #
Total comments: 3
Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Patch Set 5 : #Patch Set 6 : #Messages
Total messages: 22 (8 generated)
hpayer@chromium.org changed reviewers: + mlippautz@chromium.org, ulan@chromium.org
https://codereview.chromium.org/1268663004/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1268663004/diff/1/src/heap/mark-compact.cc#ne... src/heap/mark-compact.cc:3063: Space* owner = p->owner(); owner() could actually return lo
https://codereview.chromium.org/1268663004/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1268663004/diff/1/src/heap/mark-compact.cc#ne... src/heap/mark-compact.cc:3064: if (owner == heap_->lo_space() || owner == NULL) { Did you mean if (owner == heap_->lo_space()) { ?
https://codereview.chromium.org/1268663004/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1268663004/diff/1/src/heap/mark-compact.cc#ne... src/heap/mark-compact.cc:3064: if (owner == heap_->lo_space() || owner == NULL) { On 2015/07/30 12:45:23, ulan wrote: > Did you mean if (owner == heap_->lo_space()) { ? As discussed offline, NULL is returned when we somewhere after 1M in a large object. I will clean the owner() function up in a different cl.
I added an explicit check for slots buffer: we should never see recorded slots buffer slots for them. This check will go away as soon as we record slots in large objects.
lgtm
The CQ bit was checked by hpayer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268663004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/8147)
The CQ bit was checked by hpayer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/1268663004/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268663004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268663004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/8225)
After investigating the crasher on the build bots. Fact: we record slots for large objects in full GCs, but not when incremental marking is on.
The CQ bit was checked by hpayer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/1268663004/#ps100001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268663004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268663004/100001
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/82e1069330a9cdc692602fef766d1aec5b9e9328 Cr-Commit-Position: refs/heads/master@{#29979} |
