Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: LayoutTests/http/tests/serviceworker/update.html

Issue 1268663003: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink Layout 3/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/serviceworker/update.html
diff --git a/LayoutTests/http/tests/serviceworker/update.html b/LayoutTests/http/tests/serviceworker/update.html
index 9eb392a9898336b51f14b1d476611b9d50b2046c..5cab7f0b8893091cccd4d04a3b4210f5a1f6db55 100644
--- a/LayoutTests/http/tests/serviceworker/update.html
+++ b/LayoutTests/http/tests/serviceworker/update.html
@@ -24,8 +24,7 @@ promise_test(function(t) {
'active should exist in the initial state');
// A new worker should be found.
- registration.update();
- return wait_for_update(t, registration);
zino 2015/08/03 13:43:56 Looks good to me but would you please clarify one
jungkees 2015/08/05 02:09:31 wait_for_update() helper function is more generall
+ return registration.update();
})
.then(function() {
assert_equals(registration.installing.scriptURL, expected_url,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698