[Views] Fix WidgetTest.GetRestoredBounds

ui/views/widget/widget_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 1265 matching lines @@
   // Verify origin is stable for a frameless window as well.
   widget->SetSize(kTestSize);
   EXPECT_EQ(kTestBounds.origin().ToString(),
             widget->GetWindowBoundsInScreen().origin().ToString());
 
   widget->CloseNow();
 }
 
 // Before being enabled on Mac, this was #ifdef(false).
 // TODO(tapted): Fix this for DesktopNativeWidgets on other platforms.
 #if defined(OS_MACOSX)

[tapted, 2015/07/30 03:04:35]

I wonder.... should we try

#if !defined(OS_CHROMEOS)?

Then use CreateNativeDesktopWidget() below. I think that will work.

Then the TODO and NativeWidgetGtk comments can probably be removed. (And the
Aura comment could be something like "Non-Desktop widgets need the shell to..."

[jackhou1, 2015/07/30 06:18:13]

Done. But then disabled on Linux because it doesn't work.

 // Aura needs shell to maximize/fullscreen window.
 // NativeWidgetGtk doesn't implement GetRestoredBounds.
 TEST_F(WidgetTest, GetRestoredBounds) {
   Widget* toplevel = CreateTopLevelPlatformWidget();
   EXPECT_EQ(toplevel->GetWindowBoundsInScreen().ToString(),
             toplevel->GetRestoredBounds().ToString());
   toplevel->Show();
   toplevel->Maximize();
   RunPendingMessages();
 #if defined(OS_MACOSX)
@@ skipping 18 matching lines @@
   if (IsTestingSnowLeopard()) {
     // Fullscreen not implemented for Snow Leopard.
     EXPECT_EQ(toplevel->GetWindowBoundsInScreen().ToString(),
               toplevel->GetRestoredBounds().ToString());
   } else {
     EXPECT_NE(toplevel->GetWindowBoundsInScreen().ToString(),
               toplevel->GetRestoredBounds().ToString());
   }
   EXPECT_GT(toplevel->GetRestoredBounds().width(), 0);
   EXPECT_GT(toplevel->GetRestoredBounds().height(), 0);
+
+  toplevel->CloseNow();
 }
 #endif
 
 // The key-event propagation from Widget happens differently on aura and
 // non-aura systems because of the difference in IME. So this test works only on
 // aura.
 TEST_F(WidgetTest, KeyboardInputEvent) {
   Widget* toplevel = CreateTopLevelPlatformWidget();
   View* container = toplevel->client_view();
 
@@ skipping 2103 matching lines @@
   EXPECT_FALSE(widget->IsAlwaysOnTop());
   widget->SetAlwaysOnTop(true);
   EXPECT_TRUE(widget->IsAlwaysOnTop());
   widget->SetAlwaysOnTop(false);
   EXPECT_FALSE(widget->IsAlwaysOnTop());
   widget->CloseNow();
 }
 
 }  // namespace test
 }  // namespace views