Make it easier to test changes to a .icon file.

Make it easier to test changes to a .icon file.

No need to recompile Chrome; views_examples_exe will read from a file. This would also be useful for the tool which will allow designers to create .icon files directly (which may or may not ever materialize).

Since this is potentially unsafe (could crash on the wrong inputs) and doesn't serve a purpose in Chrome itself, it's ifdef'd out of the header everywhere except those places that explicitly need it.

BUG=505953
Committed: https://crrev.com/93906afd35bf9de7ed25b174d490716b730a6044
Cr-Commit-Position: refs/heads/master@{#341667}

[Evan Stade, 2015-07-31 18:56:08]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2015-07-31 18:59:59]

https://codereview.chromium.org/1268633002/diff/20001/ui/gfx/paint_vector_ico...
File ui/gfx/paint_vector_icon.cc (right):

https://codereview.chromium.org/1268633002/diff/20001/ui/gfx/paint_vector_ico...
ui/gfx/paint_vector_icon.cc:175: class VectorIconSource : public
CanvasImageSource {
changes to this class: addition of second constructor and addition of |path_|

https://codereview.chromium.org/1268633002/diff/20001/ui/gfx/paint_vector_ico...
ui/gfx/paint_vector_icon.cc:215: class VectorIconCache {
no change to this class (just moved within file)

[Evan Stade, 2015-07-31 19:01:31]

docs

[sky, 2015-08-03 15:27:49]

LGTM

https://codereview.chromium.org/1268633002/diff/40001/ui/gfx/paint_vector_ico...
File ui/gfx/paint_vector_icon.cc (right):

https://codereview.chromium.org/1268633002/diff/40001/ui/gfx/paint_vector_ico...
ui/gfx/paint_vector_icon.cc:39: #undef RETURN_IF_IS
It would be nice if this generated a compile error when the command set changed.

https://codereview.chromium.org/1268633002/diff/40001/ui/gfx/paint_vector_icon.h
File ui/gfx/paint_vector_icon.h (right):

https://codereview.chromium.org/1268633002/diff/40001/ui/gfx/paint_vector_ico...
ui/gfx/paint_vector_icon.h:32: // Takes a string of the format expected of .icon
files and renders into onto
remove onto?

[Evan Stade, 2015-08-03 17:19:37]

https://codereview.chromium.org/1268633002/diff/40001/ui/gfx/paint_vector_ico...
File ui/gfx/paint_vector_icon.cc (right):

https://codereview.chromium.org/1268633002/diff/40001/ui/gfx/paint_vector_ico...
ui/gfx/paint_vector_icon.cc:39: #undef RETURN_IF_IS
On 2015/08/03 15:27:49, sky wrote:
> It would be nice if this generated a compile error when the command set
changed.

I agree, but the only way I can think to do that is to invert the check, turn it
into a switch statement, and add a loop. This doesn't seem very elegant, and
since this code is only used for debugging, it breaking periodically doesn't
seem that problematic.

https://codereview.chromium.org/1268633002/diff/40001/ui/gfx/paint_vector_icon.h
File ui/gfx/paint_vector_icon.h (right):

https://codereview.chromium.org/1268633002/diff/40001/ui/gfx/paint_vector_ico...
ui/gfx/paint_vector_icon.h:32: // Takes a string of the format expected of .icon
files and renders into onto
On 2015/08/03 15:27:49, sky wrote:
> remove onto?

Done.

[Evan Stade, 2015-08-03 17:20:08]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-08-03 17:20:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1268633002/#ps60001
(title: "s/onto //")

[commit-bot: I haz the power, 2015-08-03 17:20:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268633002/60001

[commit-bot: I haz the power, 2015-08-03 17:43:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 17:43:48]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Evan Stade, 2015-08-03 22:26:01]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2015-08-03 22:26:19]

https://codereview.chromium.org/1268633002/diff/80001/ui/views/examples/vecto...
File ui/views/examples/vector_example.cc (right):

https://codereview.chromium.org/1268633002/diff/80001/ui/views/examples/vecto...
ui/views/examples/vector_example.cc:105: #if defined(OS_POSIX)
is there any better way of doing this?

[commit-bot: I haz the power, 2015-08-03 22:26:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268633002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268633002/80001

[commit-bot: I haz the power, 2015-08-03 22:42:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 22:42:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-08-03 22:51:13]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-03 22:52:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268633002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268633002/100001

[commit-bot: I haz the power, 2015-08-03 23:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 23:14:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2015-08-04 00:04:38]

https://codereview.chromium.org/1268633002/diff/80001/ui/views/examples/vecto...
File ui/views/examples/vector_example.cc (right):

https://codereview.chromium.org/1268633002/diff/80001/ui/views/examples/vecto...
ui/views/examples/vector_example.cc:105: #if defined(OS_POSIX)
On 2015/08/03 22:26:19, Evan Stade wrote:
> is there any better way of doing this?

Seems like there should be, but I'm not sure.

[Evan Stade, 2015-08-04 00:37:50]

https://codereview.chromium.org/1268633002/diff/80001/ui/views/examples/vecto...
File ui/views/examples/vector_example.cc (right):

https://codereview.chromium.org/1268633002/diff/80001/ui/views/examples/vecto...
ui/views/examples/vector_example.cc:105: #if defined(OS_POSIX)
On 2015/08/04 00:04:38, sky wrote:
> On 2015/08/03 22:26:19, Evan Stade wrote:
> > is there any better way of doing this?
> 
> Seems like there should be, but I'm not sure.

well, I failed to find the magic. In tests you use FILE_PATH_LITERAL but that
doesn't help us here.

[Evan Stade, 2015-08-04 00:37:52]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-08-04 00:37:53]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1268633002/#ps120001
(title: "fix build?")

[commit-bot: I haz the power, 2015-08-04 00:38:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268633002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268633002/120001

[commit-bot: I haz the power, 2015-08-04 02:02:01]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-08-04 02:02:29]

Patchset 7 (id:??) landed as
https://crrev.com/93906afd35bf9de7ed25b174d490716b730a6044
Cr-Commit-Position: refs/heads/master@{#341667}