Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1268573002: Remove SK_BUILD_FOR SDL, BREW, and PALM. (Closed)

Created:
5 years, 4 months ago by bungeman-skia
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_BUILD_FOR SDL, BREW, and PALM. SDL isn't an OS anyway, it's just a library views can use. Remaining support for Brew was removed some time ago, and there are currently no uses of SK_BUILD_FOR_PALM. Committed: https://skia.googlesource.com/skia/+/3ac6b7551dc7aa182018f96b32f6e516305333ee

Patch Set 1 #

Total comments: 1

Patch Set 2 : elif #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M gyp/utils.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +2 lines, -6 lines 0 comments Download
M include/views/SkWindow.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268573002/1
5 years, 4 months ago (2015-07-29 19:56:05 UTC) #2
bungeman-skia
https://codereview.chromium.org/1268573002/diff/1/gyp/utils.gyp File gyp/utils.gyp (left): https://codereview.chromium.org/1268573002/diff/1/gyp/utils.gyp#oldcode39 gyp/utils.gyp:39: '../src/utils/SDL/SkOSWindow_SDL.cpp', This is actually a leftover. This source doesn't ...
5 years, 4 months ago (2015-07-29 19:56:19 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/616) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
5 years, 4 months ago (2015-07-29 19:57:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268573002/20001
5 years, 4 months ago (2015-07-29 20:00:58 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-29 20:09:35 UTC) #10
reed1
lgtm
5 years, 4 months ago (2015-07-29 20:27:56 UTC) #11
reed1
death to symbian
5 years, 4 months ago (2015-07-29 20:28:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268573002/20001
5 years, 4 months ago (2015-07-29 20:36:59 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 20:37:30 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3ac6b7551dc7aa182018f96b32f6e516305333ee

Powered by Google App Engine
This is Rietveld 408576698