Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1268553003: Test262 roll (Closed)

Created:
5 years, 4 months ago by Dan Ehrenberg
Modified:
5 years, 4 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update to latest test262 from 2015-07-31 Committed: https://crrev.com/722ad6923887d367f14588f5ccd6697b8684bd28 Cr-Commit-Position: refs/heads/master@{#30052}

Patch Set 1 #

Patch Set 2 : More test failures #

Patch Set 3 : More tests #

Patch Set 4 : no skip #

Patch Set 5 : fix issues #

Patch Set 6 : Changes based on cq dry run #

Patch Set 7 : fix another issue #

Patch Set 8 : Fix update datewq #

Patch Set 9 : fix update date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -166 lines) Patch
M test/test262-es6/test262-es6.status View 1 2 3 4 5 6 21 chunks +345 lines, -164 lines 0 comments Download
M test/test262-es6/testcfg.py View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268553003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268553003/60001
5 years, 4 months ago (2015-08-06 15:35:46 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/8342)
5 years, 4 months ago (2015-08-06 16:15:36 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268553003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268553003/80001
5 years, 4 months ago (2015-08-06 17:35:22 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/8346)
5 years, 4 months ago (2015-08-06 18:18:39 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268553003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268553003/100001
5 years, 4 months ago (2015-08-06 21:19:24 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268553003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268553003/120001
5 years, 4 months ago (2015-08-06 21:43:12 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-06 22:09:28 UTC) #14
Dan Ehrenberg
5 years, 4 months ago (2015-08-06 22:12:04 UTC) #16
adamk
lgtm
5 years, 4 months ago (2015-08-06 22:21:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268553003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268553003/160001
5 years, 4 months ago (2015-08-06 22:22:18 UTC) #19
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 4 months ago (2015-08-06 22:46:42 UTC) #20
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/722ad6923887d367f14588f5ccd6697b8684bd28 Cr-Commit-Position: refs/heads/master@{#30052}
5 years, 4 months ago (2015-08-06 22:47:07 UTC) #21
Michael Achenbach
A revert of this CL (patchset #9 id:160001) has been created in https://codereview.chromium.org/1280903002/ by machenbach@chromium.org. ...
5 years, 4 months ago (2015-08-07 06:41:15 UTC) #22
adamk
5 years, 4 months ago (2015-08-07 15:41:13 UTC) #23
Message was sent while issue was closed. 
On 2015/08/07 06:41:15, Michael Achenbach (OOO) wrote:
> A revert of this CL (patchset #9 id:160001) has been created in
> https://codereview.chromium.org/1280903002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] Lacks one test expectation for
> http://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/4573
>
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s...
> 
> 64 bits only?.

Ah, tricky, this is likely due to 32-bit Smis on 64 bit, so we pass the
pre-check and actually generate the (empty) string.

Powered by Google App Engine
This is Rietveld 408576698