Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1268513003: Revert of Optimize RGB16 blitH functions with NEON for ARM platform. (Closed)

Created:
5 years, 4 months ago by mtklein
Modified:
5 years, 4 months ago
Reviewers:
djsollen, yang.zhang, bero, caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Optimize RGB16 blitH functions with NEON for ARM platform. (patchset #2 id:20001 of https://codereview.chromium.org/1229673008/) Reason for revert: This doesn't draw correctly, e.g. our GM test named dashcubics. Good: https://gold.skia.org/img/images/0f7e8e226379afbad8a700e0a80fd8f1.png Bad: https://gold.skia.org/img/images/56ce15fc67436065a3db4b8ee31f13ae.png Original issue's description: > Optimize RGB16 blitH functions with NEON for ARM platform. > > Here are some performance resultsi on Nexus 9: > SkRGB16BlitterBlitH_neon: > +--------+-----------+ > |height | C/NEON | > +--------+-----------+ > |1 | 0.888531 | > +--------+-----------+ > |8 | 1.231800 | > +--------+-----------+ > |18 | 1.073327 | > +--------+-----------+ > |32 | 1.136991 | > +--------+-----------+ > |76 | 1.174638 | > +--------+-----------+ > |85 | 1.188551 | > +--------+-----------+ > |120 | 1.180261 | > +--------+-----------+ > |128 | 1.183726 | > +--------+-----------+ > |512 | 1.220806 | > +--------+-----------+ > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6c72d5740231f47c664a8e765a8df05cd124c88c TBR=djsollen@google.com,caryclark@google.com,reed@google.com,bero@linaro.com,yang.zhang@linaro.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/6fbd79e4bfe43853dc3ef3bbdb70e4b15822242e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M src/core/SkBlitter_RGB16.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M src/opts/SkBlitMask_opts_arm_neon.cpp View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Optimize RGB16 blitH functions with NEON for ARM platform.
5 years, 4 months ago (2015-07-30 14:03:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268513003/1
5 years, 4 months ago (2015-07-30 14:03:18 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 14:03:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6fbd79e4bfe43853dc3ef3bbdb70e4b15822242e

Powered by Google App Engine
This is Rietveld 408576698