Issue 12685006: Re-land https://codereview.chromium.org/11642018/: Add a postbuild action for executables built wi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12685006: Re-land https://codereview.chromium.org/11642018/: Add a postbuild action for executables built wi… (Closed)

Created:
7 years, 9 months ago by Alexander Potapenko

Modified:
7 years, 9 months ago

Reviewers:
Mark Mentovai, Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Re-land https://codereview.chromium.org/11642018/: Add a postbuild action for executables built with ASan on Mac OS. The action will copy the ASan dynamic runtime to the output dir and into every bundled executable being built. Unlike the previous change, this one does not touch build/all.gyp, since our target doesn't need to be built when building 'All'. BUG=170629 TBR=thakis,mark Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187566

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -0 lines)			Patch
M	build/common.gypi	View	1 2	2 chunks	+28 lines, -0 lines	0 comments	Download
A	build/mac/asan.gyp	View		1 chunk	+32 lines, -0 lines	0 comments	Download
A	build/mac/copy_asan_runtime_dylib.sh	View		1 chunk	+53 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

Folks, I'm trying to re-land https://codereview.chromium.org/11642018/ with build/all.gyp reverted. Since this is basically what you've ...

7 years, 9 months ago (2013-03-12 11:36:35 UTC) #1

Alexander Potapenko

Committed patchset #3 manually as r187566 (presubmit successful).

7 years, 9 months ago (2013-03-12 11:56:36 UTC) #2

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages