Issue 12685002: re-land r8028 without "special" Microsoft compiler warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12685002: re-land r8028 without "special" Microsoft compiler warnings (Closed)

Created:
7 years, 9 months ago by epoger

Modified:
7 years, 9 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

re-land r8028 without "special" Microsoft compiler warnings TBR=borenet Committed: https://code.google.com/p/skia/source/detail?r=8035

Patch Set 1 #

Patch Set 2 : should_fix_warnings #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -70 lines)			Patch
	M	gm/gmmain.cpp	View	1	24 chunks	+58 lines, -70 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

epoger

patchset 2 should fix these Microsoft compiler warnings that broke Windows bots: ..\..\gm\gmmain.cpp(266): warning C4800: ...

7 years, 9 months ago (2013-03-08 09:34:49 UTC) #2

epoger

Committed patchset #2 manually as r8035 (presubmit successful).

7 years, 9 months ago (2013-03-08 09:39:37 UTC) #3

epoger

Eric- please review patchset 2, and if you come up with a better fix we ...

7 years, 9 months ago (2013-03-08 09:41:34 UTC) #4

borenet

7 years, 9 months ago (2013-03-08 12:20:29 UTC) #5

On 2013/03/08 09:41:34, epoger wrote:
> Eric- please review patchset 2, and if you come up with a better fix we can
try
> it...

LGTM.  That's a reasonable fix and possibly more readable as well.

Expand Messages | Collapse Messages