Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 1268463002: Debugger: skip function prologue when computing redirect PC. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: skip function prologue when computing redirect PC. R=jkummerow@chromium.org NOTREECHECKS=true Committed: https://crrev.com/485aca6df6065790c7454348eb3aac51b6e24616 Cr-Commit-Position: refs/heads/master@{#29904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M src/debug.cc View 3 chunks +18 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
Yang
5 years, 4 months ago (2015-07-29 10:24:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268463002/1
5 years, 4 months ago (2015-07-29 10:30:43 UTC) #3
Jakob Kummerow
lgtm
5 years, 4 months ago (2015-07-29 10:33:15 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-29 11:16:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268463002/1
5 years, 4 months ago (2015-07-29 11:17:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-29 11:19:15 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 11:19:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/485aca6df6065790c7454348eb3aac51b6e24616
Cr-Commit-Position: refs/heads/master@{#29904}

Powered by Google App Engine
This is Rietveld 408576698