Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1268433005: Remove some unused strings. (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unused strings. These were used to enable the "Other sessions" menu on NTP4. This UI has already shipped AND been removed. R=thestig@chromium.org BUG=none Committed: https://crrev.com/4ebbf2963cc7d80300b6c1ef019d4bbd0ed18722 Cr-Commit-Position: refs/heads/master@{#341935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dan Beam
5 years, 4 months ago (2015-08-04 23:43:49 UTC) #1
Lei Zhang
lgtm
5 years, 4 months ago (2015-08-04 23:48:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268433005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268433005/1
5 years, 4 months ago (2015-08-05 00:34:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/94968)
5 years, 4 months ago (2015-08-05 01:48:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268433005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268433005/1
5 years, 4 months ago (2015-08-05 18:13:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 19:12:56 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 19:13:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ebbf2963cc7d80300b6c1ef019d4bbd0ed18722
Cr-Commit-Position: refs/heads/master@{#341935}

Powered by Google App Engine
This is Rietveld 408576698