Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1268403002: Automatically discover the mojoconfig file. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Automatically discover the mojoconfig file. This patch makes devtools automatically discover the `mojoconfig` file in the lowest ancestor that contains it, unless `--no-config-file` is passed or the file is indicated explicitly through `--config-file`. Fixes domokit/devtools#28. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/db2433b49dffdb46a448d6e097bb85c7812b9fba

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ben's comments. #

Patch Set 3 : Address Ben's comments. #

Total comments: 1

Patch Set 4 : Address Ben's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -18 lines) Patch
M mojo/devtools/common/devtoolslib/paths.py View 2 chunks +12 lines, -2 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_arguments.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/devtools/common/devtoolslib/shell_config.py View 1 2 3 3 chunks +32 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ppi
Hi Ben, ptal.
5 years, 4 months ago (2015-08-05 11:42:37 UTC) #1
qsr
https://codereview.chromium.org/1268403002/diff/1/mojo/devtools/common/devtoolslib/shell_config.py File mojo/devtools/common/devtoolslib/shell_config.py (right): https://codereview.chromium.org/1268403002/diff/1/mojo/devtools/common/devtoolslib/shell_config.py#newcode168 mojo/devtools/common/devtoolslib/shell_config.py:168: if config_file: Can you use: with config_file: inside the ...
5 years, 4 months ago (2015-08-05 11:50:59 UTC) #2
ppi
https://codereview.chromium.org/1268403002/diff/1/mojo/devtools/common/devtoolslib/shell_config.py File mojo/devtools/common/devtoolslib/shell_config.py (right): https://codereview.chromium.org/1268403002/diff/1/mojo/devtools/common/devtoolslib/shell_config.py#newcode168 mojo/devtools/common/devtoolslib/shell_config.py:168: if config_file: On 2015/08/05 11:50:59, qsr wrote: > Can ...
5 years, 4 months ago (2015-08-05 11:55:45 UTC) #3
qsr
LGTM with nits. https://codereview.chromium.org/1268403002/diff/40001/mojo/devtools/common/devtoolslib/shell_config.py File mojo/devtools/common/devtoolslib/shell_config.py (right): https://codereview.chromium.org/1268403002/diff/40001/mojo/devtools/common/devtoolslib/shell_config.py#newcode180 mojo/devtools/common/devtoolslib/shell_config.py:180: config_file.close() You can remove the close ...
5 years, 4 months ago (2015-08-05 12:02:33 UTC) #4
ppi
5 years, 4 months ago (2015-08-05 12:04:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
db2433b49dffdb46a448d6e097bb85c7812b9fba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698