Issue 12684015: Fix Dartium WebGL regression. Remove default case in switch to catch this early next time when the …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12684015: Fix Dartium WebGL regression. Remove default case in switch to catch this early next time when the … (Closed)

Created:
7 years, 9 months ago by Mads Ager (google)

Modified:
7 years, 9 months ago

Reviewers:
Anton Muhin

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

Fix Dartium WebGL regression. Remove default case in switch to catch this early next time when the switch does not cover all cases. R=antonm@google.com BUG=dartbug.com/9258 Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1136

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp	View		4 chunks	+12 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Mads Ager (google)

Committed patchset #1 manually as r1136 (presubmit successful).

7 years, 9 months ago (2013-03-19 08:46:46 UTC) #3

Message was sent while issue was closed.

LGTM

thanks a lot for fixing it