Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: chrome/browser/chrome_browser_field_trials.cc

Issue 12684010: Add simple cache backend experiment hidden behind a flag. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_field_trials.cc
diff --git a/chrome/browser/chrome_browser_field_trials.cc b/chrome/browser/chrome_browser_field_trials.cc
index 1c9a854e5c034f3c4c1a199cb271b27e3dab09aa..904d5ab594baf873ed313c00903c98961c94b3d1 100644
--- a/chrome/browser/chrome_browser_field_trials.cc
+++ b/chrome/browser/chrome_browser_field_trials.cc
@@ -59,6 +59,7 @@ ChromeBrowserFieldTrials::~ChromeBrowserFieldTrials() {
void ChromeBrowserFieldTrials::SetupFieldTrials(
const base::Time& install_time) {
chrome_variations::SetupUniformityFieldTrials(install_time);
+ SetUpSimpleCacheFieldTrial();
SteveT 2013/03/15 14:07:05 We might want to wrap this in a SetupAndroidFieldT
pasko-google - do not use 2013/03/15 15:36:28 That makes sense in general. Right now we want it
#if !defined(OS_ANDROID)
SetupDesktopFieldTrials();
#endif // defined(OS_ANDROID)
@@ -191,6 +192,18 @@ void ChromeBrowserFieldTrials::DisableShowProfileSwitcherTrialIfNecessary() {
}
}
+void ChromeBrowserFieldTrials::SetUpSimpleCacheFieldTrial() {
+ if (parsed_command_line_.HasSwitch(switches::kUseSimpleCacheBackend)) {
SteveT 2013/03/15 14:07:05 You want the user to turn on the switch in order t
pasko-google - do not use 2013/03/15 15:36:28 Yes. This will change when we tune the experiment
+ const base::FieldTrial::Probability kDivisor = 100;
+ base::FieldTrial::Probability simple_cache_probability = 100;
+ scoped_refptr<base::FieldTrial> trial(
+ base::FieldTrialList::FactoryGetFieldTrial("SimpleCacheTrial", kDivisor,
+ "No", 2013, 12, 31, NULL));
+ trial->UseOneTimeRandomization();
+ trial->AppendGroup("Yes", simple_cache_probability);
SteveT 2013/03/15 14:07:05 This sets up the trial so that everyone gets the "
pasko-google - do not use 2013/03/15 15:36:28 Yes, exactly. It is the way to enable a 100% exper
+ }
+}
+
void ChromeBrowserFieldTrials::SetUpCacheSensitivityAnalysisFieldTrial() {
const base::FieldTrial::Probability kDivisor = 100;

Powered by Google App Engine
This is Rietveld 408576698