Multicast socket API

chrome/browser/extensions/api/socket/udp_socket_unittest.cc

Index: chrome/browser/extensions/api/socket/udp_socket_unittest.cc
diff --git a/chrome/browser/extensions/api/socket/udp_socket_unittest.cc b/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
index c625efecdf27b66d73dbb2bde3d4639d2cacfa3c..7b9bd5929204b7aaf0596e8c9949c237fa097802 100644
--- a/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
+++ b/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
@@ -20,7 +20,7 @@ class UDPSocketUnitTest : public BrowserWithTestWindowTest {
 };
 
 static void OnConnected(int result) {
-  DCHECK(result == 0);
+  EXPECT_EQ(result, 0);

[mmenke, 2013/04/12 21:07:41]

Expected value should be the first argument, the value you're testing the
second.

Goes for the rest of this file, too.  (Order doesn't matter for anything other
than EQ and NE)

[Bei Zhang, 2013/04/15 22:30:26]

Done.

 }
 
 static void OnCompleted(int bytes_read,
@@ -30,6 +30,19 @@ static void OnCompleted(int bytes_read,
   // Do nothing; don't care.
 }
 
+static const char test_message[] = "$$TESTMESSAGETESTMESSAGETESTMESSAGETEST$$";
+
+static void OnReadCompleted(int count,
+                            scoped_refptr<net::IOBuffer> io_buffer) {
+  size_t expected_size = arraysize(test_message);
+  EXPECT_EQ((size_t)(count), expected_size);
+  EXPECT_EQ(strncmp(io_buffer->data(), test_message, expected_size), 0);
+}
+
+static void OnSendCompleted(int result) {
+  EXPECT_EQ((size_t)(result), arraysize(test_message));
+}
+
 TEST(UDPSocketUnitTest, TestUDPSocketRecvFrom) {
   MessageLoopForIO io_loop;  // for RecvFrom to do its threaded work.
   UDPSocket socket("abcdefghijklmnopqrst");
@@ -41,4 +54,32 @@ TEST(UDPSocketUnitTest, TestUDPSocketRecvFrom) {
   socket.RecvFrom(4096, base::Bind(&OnCompleted));
 }
 
+TEST(UDPSocketUnitTest, TestUDPMulticast) {
+  const char* kGroup = "237.132.100.17";
+  MessageLoopForIO io_loop;  // for RecvFrom to do its threaded work.

[mmenke, 2013/04/12 21:07:41]

Comments should generally start with a capital.

[Bei Zhang, 2013/04/15 22:30:26]

Done.

+  UDPSocket src("abcdefghijklmnopqrst");
+  UDPSocket dest("abcdefghijklmnopqrst");
+
+  EXPECT_EQ(dest.Bind("0.0.0.0", 13333), 0);
+  EXPECT_EQ(dest.JoinGroup(kGroup), 0);
+  dest.Read(1024, base::Bind(&OnReadCompleted));
+
+  size_t size = arraysize(test_message);
+  scoped_refptr<net::IOBuffer> data =
+      new net::WrappedIOBuffer(test_message);
+  // Setting multicast setting s should work even before connection.
+  EXPECT_NE(src.SetMulticastTimeToLive(-1), 0);
+  EXPECT_EQ(src.SetMulticastTimeToLive(3), 0);
+  EXPECT_EQ(src.SetMulticastTimeToLive(0), 0);
+  EXPECT_EQ(src.SetMulticastLoopbackMode(false), 0);
+  EXPECT_EQ(src.SetMulticastLoopbackMode(true), 0);
+  src.Connect(kGroup, 13333, base::Bind(&OnConnected));
+  EXPECT_NE(src.SetMulticastTimeToLive(-1), 0); // Negative TTL shall fail

[mmenke, 2013/04/12 21:07:41]

Comments should generally end with a period.

[mmenke, 2013/04/12 21:07:41]

2 spaces before comment.

[Bei Zhang, 2013/04/15 22:30:26]

Done.

[Bei Zhang, 2013/04/15 22:30:26]

Done.

+  EXPECT_EQ(src.SetMulticastTimeToLive(3), 0);
+  EXPECT_EQ(src.SetMulticastTimeToLive(0), 0);
+  EXPECT_EQ(src.SetMulticastLoopbackMode(false), 0);
+  EXPECT_EQ(src.SetMulticastLoopbackMode(true), 0);
+  src.SendTo(data, size, kGroup, 13333, base::Bind(&OnSendCompleted));
+}
+
 }  // namespace extensions