Multicast socket API

chrome/browser/extensions/api/socket/udp_socket.h

Index: chrome/browser/extensions/api/socket/udp_socket.h
diff --git a/chrome/browser/extensions/api/socket/udp_socket.h b/chrome/browser/extensions/api/socket/udp_socket.h
index 8e2d2e66f69b4ca01b1f9e41714a2a2c5a4f9d2b..e3370838c579bf5c5807b4e2fc749f5feda48146 100644
--- a/chrome/browser/extensions/api/socket/udp_socket.h
+++ b/chrome/browser/extensions/api/socket/udp_socket.h
@@ -7,6 +7,7 @@
 
 #include <string>
 
+#include "base/hash_tables.h"
 #include "chrome/browser/extensions/api/socket/socket.h"
 #include "net/udp/udp_socket.h"
 
@@ -35,6 +36,14 @@ class UDPSocket : public Socket {
   virtual bool GetLocalAddress(net::IPEndPoint* address) OVERRIDE;
   virtual Socket::SocketType GetSocketType() const OVERRIDE;
 
+  int JoinGroup(const std::string& address);
+  int LeaveGroup(const std::string& address);
+
+  int SetMulticastTimeToLive(int ttl);
+  int SetMulticastLoopbackMode(bool loopback);
+
+  int GetJoinedGroups(base::hash_set<std::string>* groups) const;

[wtc, 2013/04/17 22:06:50]

I think you should document these five new methods. This is
outside my area, so I don't know if your team requires this.

[Bei Zhang, 2013/04/19 19:40:14]

None of the method is documented here. I guess it's because it is just a wrapper
of another class.

On 2013/04/17 22:06:50, wtc wrote:

[wtc, 2013/04/22 19:19:52]

The existing methods are all implementations of base class
methods (note that they all have the OVERRIDE keyword).
They don't need to be documented in a subclass.

The five new methods you added should be documented.
Since this file is outside src/net, I won't insist that
you document the new methods. You should follow the policy
of the extensions team.

+
  protected:
   virtual int WriteImpl(net::IOBuffer* io_buffer,
                         int io_buffer_size,
@@ -58,6 +67,8 @@ class UDPSocket : public Socket {
   RecvFromCompletionCallback recv_from_callback_;
 
   CompletionCallback send_to_callback_;
+
+  base::hash_set<std::string> multicast_groups_;
 };
 
 }  //  namespace extensions