Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7183)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/permissions/socket_permission_unittest.cc

Issue 12684008: Multicast socket API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor fixes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/extensions/permissions/socket_permission_data.cc ('K') | « chrome/common/extensions/permissions/socket_permission_data.cc ('k') | chrome/test/data/extensions/api_test/socket/api/background.js » ('j') | chrome/test/data/extensions/api_test/socket/api/multicast.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/socket_permission_unittest.cc
diff --git a/chrome/common/extensions/permissions/socket_permission_unittest.cc b/chrome/common/extensions/permissions/socket_permission_unittest.cc
index 05e7d3df3d2070fd157aef8e1836eb0e4c306d85..7f465ca1b5b0a7288c1dc702538709ed7f0e62e2 100644
--- a/chrome/common/extensions/permissions/socket_permission_unittest.cc
+++ b/chrome/common/extensions/permissions/socket_permission_unittest.cc
@@ -198,6 +198,25 @@ TEST_F(SocketPermissionTest, Match) {
param.reset(new SocketPermission::CheckParam(
SocketPermissionRequest::TCP_CONNECT, "192.168.0.1", 8800));
EXPECT_FALSE(data.Check(param.get()));
+
+ ASSERT_FALSE(data.ParseForTest("udp-multicast-membership:*"));
+ ASSERT_FALSE(data.ParseForTest("udp-multicast-membership:*:*"));
+ ASSERT_TRUE(data.ParseForTest("udp-multicast-membership"));
+ param.reset(new SocketPermission::CheckParam(
+ SocketPermissionRequest::UDP_BIND, "127.0.0.1", 8800));
+ EXPECT_FALSE(data.Check(param.get()));
+ param.reset(new SocketPermission::CheckParam(
+ SocketPermissionRequest::UDP_BIND, "127.0.0.1", 8888));
+ EXPECT_FALSE(data.Check(param.get()));
+ param.reset(new SocketPermission::CheckParam(
+ SocketPermissionRequest::TCP_CONNECT, "www.example.com", 80));
+ EXPECT_FALSE(data.Check(param.get()));
+ param.reset(new SocketPermission::CheckParam(
+ SocketPermissionRequest::UDP_SEND_TO, "www.google.com", 8800));
+ EXPECT_FALSE(data.Check(param.get()));
+ param.reset(new SocketPermission::CheckParam(
+ SocketPermissionRequest::UDP_MUTICAST_MEMBERSHIP, "127.0.0.1", 35));
+ EXPECT_TRUE(data.Check(param.get()));
}
TEST_F(SocketPermissionTest, IPC) {
« chrome/common/extensions/permissions/socket_permission_data.cc ('K') | « chrome/common/extensions/permissions/socket_permission_data.cc ('k') | chrome/test/data/extensions/api_test/socket/api/background.js » ('j') | chrome/test/data/extensions/api_test/socket/api/multicast.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698