content/browser/android/in_process/synchronous_compositor_context_provider.cc - Issue 1268383003: Sync compositor: Ignore command buffer memory callback

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/android/in_process/synchronous_compositor_context_provider.cc

Issue 1268383003: Sync compositor: Ignore command buffer memory callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/android/in_process/synchronous_compositor_context_provider.h ('k') | content/browser/android/in_process/synchronous_compositor_factory_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/browser/android/in_process/synchronous_compositor_context_prov ider.h"

	6

	7 namespace content {

	8

	9 SynchronousCompositorContextProvider::SynchronousCompositorContextProvider(

	10 scoped_ptr<WebGraphicsContext3DCommandBufferImpl> context3d,

	11 CommandBufferContextType type)

	12 : ContextProviderCommandBuffer(context3d.Pass(), type, false) {}

	13

	14 SynchronousCompositorContextProvider::~SynchronousCompositorContextProvider() {}

	15

	16 void SynchronousCompositorContextProvider::SetMemoryPolicyChangedCallback(

	17 const MemoryPolicyChangedCallback& memory_policy_changed_callback) {

	18 // Intentional no-op.
	no sievers 2015/08/05 22:31:27 But this can be NOTREACHED() then? But this can be NOTREACHED() then? boliu 2015/08/05 22:35:04 Nope.. it's still called. But this override is tec Show quoted text On 2015/08/05 22:31:27, sievers wrote: > But this can be NOTREACHED() then? Nope.. it's still called. But this override is technically not really needed. Setting the callback in provider doesn't hurt anything, as long as it's not hooked up to the command buffer. Ehh, I'll get rid of it.
	19 }

	20

	21 } // namespace content

OLD	NEW