[DevTools] Support JQuery event listeners

Source/core/inspector/InjectedScript.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
 
 #include "core/inspector/InjectedScript.h"
 
 #include "bindings/core/v8/ScriptFunctionCall.h"
 #include "bindings/core/v8/V8Binding.h"
+#include "bindings/core/v8/V8Node.h"

[yurys, 2015/08/12 21:56:03]

Please don't add dependencies on Blink concepts into InjectedScript as we are
planning to extract it into v8 inspector.

 #include "core/inspector/InjectedScriptHost.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/inspector/InspectorTraceEvents.h"
 #include "core/inspector/JSONParser.h"
 #include "core/inspector/RemoteObjectId.h"
 #include "platform/JSONValues.h"
 #include "wtf/text/WTFString.h"
 
 using blink::TypeBuilder::Array;
 using blink::TypeBuilder::Debugger::CallFrame;
@@ skipping 279 matching lines @@
         return;
     RefPtr<JSONObject> object;
     if (!parsedObjectId->asObject(&object))
         return;
     int boundId = 0;
     if (!object->getNumber("id", &boundId))
         return;
     m_native->unbind(boundId);
 }
 
+v8::MaybeLocal<v8::Array> InjectedScript::frameworkEventListeners(v8::Local<v8::Value> object)
+{
+    v8::Isolate* isolate = injectedScriptObject().isolate();
+    if (!object.IsEmpty() && V8Node::hasInstance(object, isolate)) {

[yurys, 2015/08/12 21:56:03]

prefer early return

+        ScriptFunctionCall function(injectedScriptObject(), "frameworkEventListeners");
+        function.appendArgument(object);
+        bool hadException = false;
+        ScriptValue result = callFunctionWithEvalEnabled(function, hadException);
+        if (!hadException && !result.isEmpty())
+            return result.v8Value().As<v8::Array>();
+    }
+    return v8::MaybeLocal<v8::Array>();
+}
+
+
+v8::MaybeLocal<v8::Set> InjectedScript::frameworkEventHandlers(v8::Local<v8::Value> object)

[yurys, 2015/08/12 21:56:03]

Please use Local<> instead as the exception is not passed on further.

+{
+    v8::Isolate* isolate = injectedScriptObject().isolate();
+    if (!object.IsEmpty() && V8Node::hasInstance(object, isolate)) {
+        ScriptFunctionCall function(injectedScriptObject(), "frameworkEventHandlers");

[yurys, 2015/08/12 21:56:03]

Please extract common code into a method.

+        function.appendArgument(object);
+        bool hadException = false;
+        ScriptValue result = callFunctionWithEvalEnabled(function, hadException);
+        if (!hadException && !result.isEmpty())
+            return result.v8Value().As<v8::Set>();
+    }
+    return v8::MaybeLocal<v8::Set>();
+}
+
+
 PassRefPtr<Array<CallFrame>> InjectedScript::wrapCallFrames(v8::Local<v8::Object> callFrames, int asyncOrdinal)
 {
     ASSERT(!isEmpty());
     ScriptFunctionCall function(injectedScriptObject(), "wrapCallFrames");
     function.appendArgument(callFrames);
     function.appendArgument(asyncOrdinal);
     bool hadException = false;
     ScriptValue callFramesValue = callFunctionWithEvalEnabled(function, hadException);
     ASSERT(!hadException);
     RefPtr<JSONValue> result = toJSONValue(callFramesValue);
@@ skipping 186 matching lines @@
         *exceptionDetails = TypeBuilder::Debugger::ExceptionDetails::create().setText(text);
     } else {
         *result = toJSONValue(resultValue);
         if (!*result)
             *result = JSONString::create(String::format("Object has too long reference chain(must not be longer than %d)", JSONValue::maxDepth));
     }
 }
 
 } // namespace blink