[DevTools] Support JQuery event listeners

Source/bindings/core/v8/ScriptEventListener.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 70 matching lines @@
     ScriptController& scriptController = frame->script();
     if (!scriptController.canExecuteScripts(AboutToExecuteScript))
         return nullptr;
 
     TextPosition position = scriptController.eventHandlerPosition();
     String sourceURL = frame->document()->url().string();
 
     return V8LazyEventListener::create(name.localName(), eventParameterName, value, sourceURL, position, 0, toIsolate(frame));
 }
 
-static v8::MaybeLocal<v8::Function> eventListenerEffectiveFunction(v8::Isolate* isolate, v8::Local<v8::Context> context, v8::Local<v8::Object> listenerObject)
+v8::Local<v8::Object> eventListenerHandler(ExecutionContext* executionContext, EventListener* listener)
 {
-    if (listenerObject->IsFunction()) {
-        return v8::MaybeLocal<v8::Function>(listenerObject.As<v8::Function>());
-    } else if (listenerObject->IsObject()) {
-        // Try the "handleEvent" method (EventListener interface).
-        v8::Local<v8::Value> property;
-        if (listenerObject->Get(context, v8AtomicString(isolate, "handleEvent")).ToLocal(&property) && property->IsFunction())
-            return v8::MaybeLocal<v8::Function>(property.As<v8::Function>());
-        // Fall back to the "constructor" property.
-        if (listenerObject->Get(context, v8AtomicString(isolate, "constructor")).ToLocal(&property) && property->IsFunction())
-            return v8::MaybeLocal<v8::Function>(property.As<v8::Function>());
-    }
-    return v8::MaybeLocal<v8::Function>();
+    if (listener->type() != EventListener::JSEventListenerType)
+        return v8::Local<v8::Object>();
+    V8AbstractEventListener* v8Listener = static_cast<V8AbstractEventListener*>(listener);
+    return v8Listener->getListenerObject(executionContext);
 }
 
-ScriptValue eventListenerHandler(ExecutionContext* executionContext, EventListener* listener)
+v8::Local<v8::Function> eventListenerEffectiveFunction(v8::Isolate* isolate, v8::Local<v8::Object> handler)
 {
-    if (listener->type() != EventListener::JSEventListenerType)
-        return ScriptValue();
-
-    v8::Isolate* isolate = toIsolate(executionContext);
-    v8::HandleScope scope(isolate);
-    V8AbstractEventListener* v8Listener = static_cast<V8AbstractEventListener*>(listener);
-    v8::Local<v8::Context> context = toV8Context(executionContext, v8Listener->world());
-    v8::Context::Scope contextScope(context);
-    v8::Local<v8::Object> function = v8Listener->getListenerObject(executionContext);
-    if (function.IsEmpty())
-        return ScriptValue();
-    return ScriptValue(ScriptState::from(context), function);
+    v8::Local<v8::Function> function;
+    if (handler->IsFunction()) {
+        function = handler.As<v8::Function>();
+    } else if (handler->IsObject()) {
+        v8::Local<v8::Value> property;
+        // Try the "handleEvent" method (EventListener interface).
+        if (handler->Get(handler->CreationContext(), v8AtomicString(isolate, "handleEvent")).ToLocal(&property) && property->IsFunction())
+            function = property.As<v8::Function>();
+        // Fall back to the "constructor" property.
+        else if (handler->Get(handler->CreationContext(), v8AtomicString(isolate, "constructor")).ToLocal(&property) && property->IsFunction())
+            function = property.As<v8::Function>();
+    }
+    if (!function.IsEmpty())
+        return getBoundFunction(function);
+    return v8::Local<v8::Function>();
 }
 
-ScriptState* eventListenerHandlerScriptState(LocalFrame* frame, EventListener* listener)
+void functionLocation(v8::Local<v8::Function> function, String& scriptId, int& lineNumber, int& columnNumber)

[yurys, 2015/08/11 21:10:24]

style: getFunctionLocation since we use return parameters here.

[kozy, 2015/08/12 18:02:22]

Done.

 {
-    if (listener->type() != EventListener::JSEventListenerType)
-        return 0;
-    V8AbstractEventListener* v8Listener = static_cast<V8AbstractEventListener*>(listener);
-    v8::HandleScope scope(toIsolate(frame));
-    v8::Local<v8::Context> v8Context = frame->script().windowProxy(v8Listener->world())->context();
-    return ScriptState::from(v8Context);
-}
-
-bool eventListenerHandlerLocation(ExecutionContext* executionContext, EventListener* listener, String& scriptId, int& lineNumber, int& columnNumber)
-{
-    if (listener->type() != EventListener::JSEventListenerType)
-        return false;
-
-    v8::HandleScope scope(toIsolate(executionContext));
-    V8AbstractEventListener* v8Listener = static_cast<V8AbstractEventListener*>(listener);
-    v8::Local<v8::Context> context = toV8Context(executionContext, v8Listener->world());
-    v8::Context::Scope contextScope(context);
-    v8::Local<v8::Object> object = v8Listener->getListenerObject(executionContext);
-    if (object.IsEmpty())
-        return false;
-    v8::Local<v8::Function> function;
-    if (!eventListenerEffectiveFunction(scope.GetIsolate(), context, object).ToLocal(&function))
-        return false;
-    v8::Local<v8::Function> originalFunction = getBoundFunction(function);
-    int scriptIdValue = originalFunction->ScriptId();
+    int scriptIdValue = function->ScriptId();
     scriptId = String::number(scriptIdValue);
-    lineNumber = originalFunction->GetScriptLineNumber();
-    columnNumber = originalFunction->GetScriptColumnNumber();
-    return true;
+    lineNumber = function->GetScriptLineNumber();
+    columnNumber = function->GetScriptColumnNumber();
 }
 
 } // namespace blink