Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1268333004: Introduce object visitor to estimate the size of a native context. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce object visitor to estimate the size of a native context. This is only an estimate since it counts objects that could be shared, for example strings, cow arrays, heap numbers, etc. It however ignores objects that could be shared, but may only be used by the context to be measured, for example shared function infos, script objects, scope infos, etc. R=jochen@chromium.org Committed: https://crrev.com/0a1a714f7e700b3d882e3485008fa5a24cf80584 Cr-Commit-Position: refs/heads/master@{#30029}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Patch Set 3 : use size_t #

Patch Set 4 : fix compare #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -1 line) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M include/v8.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
A src/context-measure.h View 1 chunk +47 lines, -0 lines 0 comments Download
A src/context-measure.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M src/snapshot/serialize.h View 3 chunks +3 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
Yang
5 years, 4 months ago (2015-08-05 11:38:12 UTC) #1
jochen (gone - plz use gerrit)
lgtm, thx https://codereview.chromium.org/1268333004/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1268333004/diff/1/src/api.cc#newcode395 src/api.cc:395: nit. remove https://codereview.chromium.org/1268333004/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1268333004/diff/1/src/bootstrapper.cc#newcode2411 ...
5 years, 4 months ago (2015-08-05 11:39:46 UTC) #2
jochen (gone - plz use gerrit)
actually, could you also add a getter to v8::Context in include/v8.h so we could use ...
5 years, 4 months ago (2015-08-05 11:40:28 UTC) #3
Yang
Addressed comments. Another look?
5 years, 4 months ago (2015-08-05 12:02:10 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268333004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268333004/20001
5 years, 4 months ago (2015-08-05 12:03:18 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-05 12:35:06 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268333004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268333004/40001
5 years, 4 months ago (2015-08-05 12:53:51 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/8391)
5 years, 4 months ago (2015-08-05 13:02:06 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268333004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268333004/60001
5 years, 4 months ago (2015-08-05 13:33:07 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-05 13:59:09 UTC) #16
Yang
On 2015/08/05 13:59:09, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 4 months ago (2015-08-05 14:04:16 UTC) #17
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-08-05 14:04:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268333004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268333004/60001
5 years, 4 months ago (2015-08-05 14:05:00 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-05 14:07:23 UTC) #21
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 14:07:56 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0a1a714f7e700b3d882e3485008fa5a24cf80584
Cr-Commit-Position: refs/heads/master@{#30029}

Powered by Google App Engine
This is Rietveld 408576698