Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1268323003: Support running w/ Sky from a local checkout through a config file. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Support running w/ Sky from a local checkout through a config file. This adds an alternative config file that one can use to run Sky apps using sky_viewer and SDK packages from a local sky_engine checkout. To use this you need to check out sky_engine (https://github.com/domokit/sky_engine ) and build for Android. Then, run the lengthy command-line: mojo/devtools/common/mojo_run \ --android \ --config-file mojo/tools/configs/sky \ --config-alias SKY_SRC=/path_to_your_checkout/sky_engine/src \ "mojo:window_manager https://sky/examples/hello_world/lib/main.dart" The sky apps are served from the Sky checkout, so all of sky/packages/sky/example is available under https://sky/examples . This replaces the old support for '--sky' flag, which was not enough to run w/ sky after the repo split anyway. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a2bc80458262f5a9b1edabbae294ea0d8d67cdb8

Patch Set 1 #

Patch Set 2 : Drop the legacy sky support. #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : Address Ben's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -50 lines) Patch
M mojo/devtools/common/README.md View 1 1 chunk +0 lines, -21 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_arguments.py View 1 2 chunks +6 lines, -23 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_config.py View 1 2 3 6 chunks +21 lines, -6 lines 0 comments Download
A mojo/tools/configs/README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/tools/configs/sky View 1 2 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ppi
Hi Ben, ptal.
5 years, 4 months ago (2015-08-07 12:39:14 UTC) #2
qsr
lgtm https://codereview.chromium.org/1268323003/diff/40001/mojo/devtools/common/devtoolslib/shell_config.py File mojo/devtools/common/devtoolslib/shell_config.py (right): https://codereview.chromium.org/1268323003/diff/40001/mojo/devtools/common/devtoolslib/shell_config.py#newcode199 mojo/devtools/common/devtoolslib/shell_config.py:199: Why this blank line?
5 years, 4 months ago (2015-08-07 13:20:33 UTC) #3
ppi
https://codereview.chromium.org/1268323003/diff/40001/mojo/devtools/common/devtoolslib/shell_config.py File mojo/devtools/common/devtoolslib/shell_config.py (right): https://codereview.chromium.org/1268323003/diff/40001/mojo/devtools/common/devtoolslib/shell_config.py#newcode199 mojo/devtools/common/devtoolslib/shell_config.py:199: On 2015/08/07 13:20:33, qsr wrote: > Why this blank ...
5 years, 4 months ago (2015-08-07 13:24:09 UTC) #4
ppi
5 years, 4 months ago (2015-08-07 14:07:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
a2bc80458262f5a9b1edabbae294ea0d8d67cdb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698