s/use_alternate_protocols/use_alternative_services/g

s/use_alternate_protocols/use_alternative_services/g

Rename HttpNetworkSession::Params::use_alternate_protocols,
SpdySessionDependencies::use_alternate_protocols, and
IOThread::Globals::use_alternate_protocols to use_alternative_services.

Also reformat some test-level comments, and remove some obsolete comments.

BUG=392575
Committed: https://crrev.com/55ff9daac8079a4fc81c587a4c929a2690429227
Cr-Commit-Position: refs/heads/master@{#344284}

[Bence, 2015-08-11 19:49:37]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2015-08-11 19:49:37]

Ryan: PTAL.  Thanks.

[Ryan Hamilton, 2015-08-12 03:31:15]

lgtm, modulo one question...

https://codereview.chromium.org/1268313004/diff/1/net/http/http_network_trans...
File net/http/http_network_transaction_unittest.cc (left):

https://codereview.chromium.org/1268313004/diff/1/net/http/http_network_trans...
net/http/http_network_transaction_unittest.cc:9405: //
HttpStreamFactory::set_use_alternate_protocols(false);
What's the story behind this change?

[Bence, 2015-08-12 12:02:10]

PTAL.

https://codereview.chromium.org/1268313004/diff/1/net/http/http_network_trans...
File net/http/http_network_transaction_unittest.cc (left):

https://codereview.chromium.org/1268313004/diff/1/net/http/http_network_trans...
net/http/http_network_transaction_unittest.cc:9405: //
HttpStreamFactory::set_use_alternate_protocols(false);
On 2015/08/12 03:31:15, Ryan Hamilton wrote:
> What's the story behind this change?

I have no idea.  This line got commented out at
https://codereview.chromium.org/284423002/diff/370001/net/http/http_network_t...,
starting from its Patch Set 1, without any  explanation.  The test looks fine
for me without this function call.

[Bence, 2015-08-13 10:34:04]

Patchset #2 (id:20001) has been deleted

[Bence, 2015-08-13 10:45:12]

bnc@chromium.org changed reviewers:
+ eroman@chromium.org, gunsch@chromium.org, jeremyim@chromium.org,
mef@chromium.org, sergeyu@chromium.org, torne@chromium.org

[Bence, 2015-08-13 10:45:13]

torne: PTAL android_webview/browser/net/aw_url_request_context_getter.cc
eroman: PTAL chrome/browser/resources/net_internals/spdy_view.html
gunsch: PTAL chromecast/browser/url_request_context_factory.cc
jeremyim: PTAL
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
mef: PTAL ios/crnet/crnet_environment.mm
sergeyu: PTAL jingle/glue/proxy_resolving_client_socket.cc

Thank you all.

[Torne, 2015-08-13 10:57:43]

android_webview LGTM

[gunsch, 2015-08-13 13:23:58]

chromecast lgtm

[mef, 2015-08-13 14:49:07]

crnet lgtm

[jeremyim, 2015-08-13 17:01:46]

components/drp lgtm

[Ryan Hamilton, 2015-08-13 17:03:23]

lgtm

[Bence, 2015-08-17 13:56:51]

ping eroman
ping sergeyu

[Sergey Ulanov, 2015-08-17 23:28:22]

jingle lgtm

[eroman, 2015-08-18 01:05:15]

https://codereview.chromium.org/1268313004/diff/1/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/spdy_view.html (right):

https://codereview.chromium.org/1268313004/diff/1/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/spdy_view.html:4: <li>Use Alternative
Service: <span jscontent="use_alternative_services"></span></li>
does this break loading of older log files which use the old name? See how this
is handled on line 87 for instance.

Once that is addressed LGTM

[Bence, 2015-08-19 15:32:47]

Patchset #2 (id:40001) has been deleted

[Bence, 2015-08-19 18:06:01]

The CQ bit was checked by bnc@chromium.org

[Bence, 2015-08-19 18:06:01]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org,
sergeyu@chromium.org, rch@chromium.org, gunsch@chromium.org,
eroman@chromium.org, jeremyim@chromium.org, mef@chromium.org
Link to the patchset: https://codereview.chromium.org/1268313004/#ps80001
(title: "Re: #15.")

[commit-bot: I haz the power, 2015-08-19 18:06:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268313004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268313004/80001

[Bence, 2015-08-19 18:19:33]

Thank you everybody.

https://codereview.chromium.org/1268313004/diff/1/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/spdy_view.html (right):

https://codereview.chromium.org/1268313004/diff/1/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/spdy_view.html:4: <li>Use Alternative
Service: <span jscontent="use_alternative_services"></span></li>
On 2015/08/18 01:05:15, eroman wrote:
> does this break loading of older log files which use the old name? See how
this
> is handled on line 87 for instance.
> 
> Once that is addressed LGTM

Oops, sorry about the oversight.  Fixed.

[commit-bot: I haz the power, 2015-08-19 18:42:44]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-08-19 18:43:45]

Patchset 3 (id:??) landed as
https://crrev.com/55ff9daac8079a4fc81c587a4c929a2690429227
Cr-Commit-Position: refs/heads/master@{#344284}