Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 1268273003: [turbofan] Remove kInterpreterDispatch CallDescriptor kind in favor of flag. (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove kInterpreterDispatch CallDescriptor kind in favor of flag. Rationale: The {kind} of a call descriptor describes what the {target} being called is--i.e. a JSFunction, code object, or address. That kind materially dictates the instruction(s) generated for an outgoing call. The other flags on a call descriptor should describe specific properties (like whether a roots register is valid or not) so that backend logic doesn't have to switch over the kind, but is informed directly of what it wants to know. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/8b56ec9ccc66496d631ca32d372480f0964cbb7d Cr-Commit-Position: refs/heads/master@{#30065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -35 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/linkage.h View 3 chunks +1 line, -3 lines 0 comments Download
M src/compiler/linkage.cc View 3 chunks +14 lines, -15 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 4 months ago (2015-08-07 11:21:20 UTC) #1
Michael Starzinger
LGTM. I like it.
5 years, 4 months ago (2015-08-07 11:26:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268273003/1
5 years, 4 months ago (2015-08-07 11:29:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 11:46:14 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 11:46:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b56ec9ccc66496d631ca32d372480f0964cbb7d
Cr-Commit-Position: refs/heads/master@{#30065}

Powered by Google App Engine
This is Rietveld 408576698