Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1268243003: Remove |browser_| from WebsiteSettingsPopupView. (Closed)

Created:
5 years, 4 months ago by jackhou1
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, markusheintz_, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@enabledialogs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove |browser_| from WebsiteSettingsPopupView. It's only needed to OpenURL(), which WebContents can also do. Also remove unused headers and forward-decls. BUG=None. Committed: https://crrev.com/a589acd53b7a9028b2c7690a3347f23ca3832919 Cr-Commit-Position: refs/heads/master@{#342764}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused headers. #

Patch Set 3 : Sync and rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -26 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.h View 1 5 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 4 chunks +7 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
jackhou1
sky, could you take a look?
5 years, 4 months ago (2015-08-10 12:51:03 UTC) #2
sky
LGTM https://codereview.chromium.org/1268243003/diff/1/chrome/browser/ui/views/website_settings/website_settings_popup_view.h File chrome/browser/ui/views/website_settings/website_settings_popup_view.h (right): https://codereview.chromium.org/1268243003/diff/1/chrome/browser/ui/views/website_settings/website_settings_popup_view.h#newcode21 chrome/browser/ui/views/website_settings/website_settings_popup_view.h:21: class Browser; If you can, remove this and ...
5 years, 4 months ago (2015-08-10 15:08:17 UTC) #3
jackhou1
https://codereview.chromium.org/1268243003/diff/1/chrome/browser/ui/views/website_settings/website_settings_popup_view.h File chrome/browser/ui/views/website_settings/website_settings_popup_view.h (right): https://codereview.chromium.org/1268243003/diff/1/chrome/browser/ui/views/website_settings/website_settings_popup_view.h#newcode21 chrome/browser/ui/views/website_settings/website_settings_popup_view.h:21: class Browser; On 2015/08/10 15:08:17, sky wrote: > If ...
5 years, 4 months ago (2015-08-11 01:03:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268243003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268243003/40001
5 years, 4 months ago (2015-08-11 01:03:11 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-11 01:08:09 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 01:08:39 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a589acd53b7a9028b2c7690a3347f23ca3832919
Cr-Commit-Position: refs/heads/master@{#342764}

Powered by Google App Engine
This is Rietveld 408576698